Tests: Reduce usage of assertEquals for 6.6

[SergeyBiryukov]

Follow-up to:

• #59655 (6.5)
• #58956 (6.4)
• #57855 (6.3)
• #56800 (6.2)
• #55654 (6.1)
• #54726 (6.0)
• #53364 (5.9)
• #52482 (5.8)
• #38266 (5.7)

The assertEquals() test method does not check that the types of the expected and actual values match. This can hide subtle bugs especially when the values are falsey.

Tasks:

• Switch to using assertSame() when the type of the value in the assertion is important
• Replace overall usage of assertEquals() with type-strict assertion methods, with the aim of potentially removing its usage altogether

To help ease the effort of merging tests, changes should also be made upstream in the Gutenberg repository.

This PR replaces assertEquals() with more appropriate, stricter assertions where possible and without making any changes to source.

For easier reviewing, commits have been separated based on the replacement assertion and any additional changes required to implement the stricter assertion.

Trac ticket: https://core.trac.wordpress.org/ticket/60706
Trac ticket: https://core.trac.wordpress.org/ticket/59655
Trac ticket: https://core.trac.wordpress.org/ticket/55654

[SergeyBiryukov]

In 58044:

Tests: Use assertSame() in WP_oEmbed_Controller tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [41047].

Props costdev.
See #60706.

[SergeyBiryukov]

In 58052:

Tests: Use assertSame() in wp_handle_comment_submission() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [38778], [46829].

Props costdev.
See #60706.

[SergeyBiryukov]

In 58054:

Tests: Use assertSame() in WP_Comment::get_instance() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [38381].

Props costdev.
See #60706.

[SergeyBiryukov]

In 58070:

Tests: Use assertSame() in wp_validate_redirect() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [36444].

Props costdev.
See #60706.

[SergeyBiryukov]

In 58150:

Tests: Use assertSame() in absint() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Includes correcting a few erroneously duplicated test cases to match their intended purpose.

Follow-up to [57724].

See #60706.

[SergeyBiryukov]

In 58160:

Tests: Use assertSame() in block_has_support() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [56382].

See #60706.

[SergeyBiryukov]

In 58478:

Tests: Use assertSame() in WP_Theme_JSON tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [55959], [55986], [57547], [57716], [58244], [58422].

See #60706.

[desrosj]

@SergeyBiryukov Do you have any further plans for this during 6.6 or can we close and open a new one for 6.7?

[SergeyBiryukov]

Closing this one, created #61573 for 6.7.