Get WordPress

Make WordPress Core

Opened 6 months ago

Last modified 6 months ago

#60448 new defect (bug)

Iframe from `$errmsg` is now removed from error message in the plugins page

Reported by: renathoc's profile renathoc Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.3
Component: Plugins Keywords:
Focuses: administration Cc:

Description (last modified by sabernhardt)

We have a die with a message in case of a plugin activation failure here: ​https://github.com/Automattic/sensei/blob/1933acc544be8a98866bec1b8790a5b195d5b4c7/sensei-lms.php#L65.

The message used to work until WordPress 6.3, and it stopped working.

I think it was broken with this change:
​changeset 56573, wp-admin/plugins.php

The reason seems to be because the iframe is now concatenated in the $errmsg variable, which is sent to the wp_admin_notice, and later it goes through the wp_kses_post, being removed.

Attachments (2)

Screenshot 2024-02-06 at 18.23.21.png​ (14.0 KB) - added by renathoc 6 months ago.
The expected behavior that used to work
Screenshot 2024-02-06 at 18.23.27.png​ (7.0 KB) - added by renathoc 6 months ago.
The current behavior

Download all attachments as: .zip

Change History (3)

@renathoc
6 months ago

The expected behavior that used to work

@renathoc
6 months ago

The current behavior

#1 @sabernhardt
6 months ago

  • Component changed from General to Plugins
  • Description modified (diff)
  • Focuses administration added
  • Version changed from 6.4 to 6.3

Could the plugins admin notice use echo wp_get_admin_notice() instead of wp_admin_notice()?

CC @joedolson @costdev

Note: See TracTickets for help on using tickets.