Get WordPress

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#60401 closed defect (bug) (fixed)

Use $length in rand_long_str() documentation

Reported by: harsh175's profile harsh175 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: docs Cc:

Description

When I review this file tests/phpunit/includes/utils.php then I find a parameter description variable changes $len to $length.

Attachments (1)

60401.patch​ (487 bytes) - added by harsh175 6 months ago.

Download all attachments as: .zip

Change History (4)

@harsh175
6 months ago

#1 @sabernhardt
5 months ago

  • Component changed from General to Build/Test Tools
  • Summary changed from Improve inline document to Use $length in rand_long_str() documentation

Thanks for the report and patch!

[50265] added that documentation. The variable name was rather confusing because the rand_str() function uses $len and rand_long_str() uses $length.

#2 @SergeyBiryukov
5 months ago

  • Milestone changed from Awaiting Review to 6.5

#3 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57749:

Build/Test Tools: Use a consistent parameter name between rand_str() and rand_long_str().

Follow-up to [36272], [50265].

Props harsh175, sabernhardt.
Fixes #60401.

Note: See TracTickets for help on using tickets.