Get WordPress

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#60165 closed defect (bug) (invalid)

Unused variable $parent_file on the settings.php file

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: coding-standards Cc:

Description

I have reviewed the settings.php file and found that the $parent_file is unused. So I think as per the coding standard we need to remove the $parent_file variable.

files: wp-admin/network/settings.php

Attachments (2)

60165.patch​ (472 bytes) - added by viralsampat 7 months ago.
I have added patch.
60165.2.patch​ (575 bytes) - added by viralsampat 7 months ago.

Download all attachments as: .zip

Change History (5)

@viralsampat
7 months ago

I have added patch.

@viralsampat
7 months ago

#1 @SergeyBiryukov
7 months ago

  • Keywords close added; dev-feedback removed

Hi there, thanks for the patch!

The $parent_file global is used later in wp-admin/admin-header.php and wp-admin/menu-header.php, so it cannot be removed.

#2 @SergeyBiryukov
7 months ago

  • Component changed from General to Administration

#3 @sabernhardt
7 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I agree to close. The $parent_file variable is used (and $title too).

Note: See TracTickets for help on using tickets.