Need update unused $errormsg variables on the rss.php file.

[upadalavipul]

I have reviewed the code and found the return $errormsg variable is commenting. if it is not used then we can remove it variable and related content. if we need to use it in the future then need to related content code commenting. As of now I related code is commenting. please review the below attached patch.

[sabernhardt]

#57107 may remove much more code from the deprecated MagpieRSS file.

If the no-op plan is delayed or undesired, there would be a small value in removing those 'commented out' lines with obsolete error functions:
​line 414
​line 426
​lines 527 to 528
​line 624

[SergeyBiryukov]

Hi there, thanks for the ticket!

Please note that wp-includes/rss.php is a former external library (MagpieRSS), which is deprecated and may be removed in the future as per #57107.

[sabernhardt]

removing code that was commented out and the $errormsg variable in _response_to_rss()

[sabernhardt]

I agree to close the ticket because the small edits I suggested have such a low value, though I uploaded a patch to show that in case someone thinks it is worth the changeset.

Of course, the code would be much cleaner than that if functions such as fetch_rss() and _response_to_rss() simply would return false (or have some other no-op method).