Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#59526 closed defect (bug) (fixed)

Twenty Twenty-Four: Fix image assets

Reported by: onemaggie's profile onemaggie Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

After renaming a few of the images we need to give them the same treatment as https://core.trac.wordpress.org/changeset/56721 so that they show up for users and include the right content.

The files affected are:

abstract-geometric-art.webp
building-exterior.webp
hotel-facade.webp
museum.webp
tourist-and-building.webp
windows.webp

Change History (8)

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
10 months ago

#2 @hellofromTonya
10 months ago

  • Component changed from General to Bundled Theme
  • Milestone changed from Awaiting Review to 6.4

Moving into 6.4. Thank you.

This ticket was mentioned in ​Slack in #core by colorful-tones. ​View the logs.
10 months ago

#4 @shailu25
10 months ago

#59531 was marked as a duplicate.

#5 @hellofromTonya
10 months ago

  • Owner set to hellofromTonya
  • Status changed from new to assigned
  • Version set to trunk

References:

As @desrosj ​noted in Make/Core slack:

Ya this is because patches do not include binary file contents. So images and font files that get added do not always make it into local environments when staging a patch or PR.

It's a limitation to GIT/SVN, as far as I know

Last edited 10 months ago by hellofromTonya (previous) (diff)

#6 @hellofromTonya
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 56775:

Twenty Twenty-Four: Fix 6.4 Beta 2 image assets.

Fixes the image assets from [56764] for the images to properly render.

Adds binary file contents (resolves 0 bytes issue) and svn:mime-type property:

  • abstract-geometric-art.webp
  • building-exterior.webp
  • hotel-facade.webp
  • museum.webp
  • tourist-and-building.webp
  • windows.webp

Updates the binary file contents for renamed images:

  • angular-roof.webp
  • art-gallery.webp
  • green-staircase.webp

Follow-up to [56764].

Unprops hellofromTonya.
Props onemaggie, luminuu, colorful-tones, desrosj, mukesh27, nendeb55, nicolefurlan, satishprajapati, shailu25.
Fixes #59526.
See #59524.

#7 @costdev
10 months ago

#59567 was marked as a duplicate.

This ticket was mentioned in ​Slack in #core by ironprogrammer. ​View the logs.
10 months ago

Note: See TracTickets for help on using tickets.