Get WordPress

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#59389 closed enhancement (fixed)

Coding Standards: Use `implode` instead of `join` in tests/phpunit/tests/media.php and tests/phpunit/tests/media/getPostGalleries.php

Reported by: davidbinda's profile david.binda Owned by: costdev's profile costdev
Milestone: 6.4 Priority: normal
Severity: normal Version: 5.9
Component: General Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

r49193 replaced multiple instances of aliased functions by the canonical ones. Since then, some new instances of join instead of implode were introduced.

Attachments (1)

59389.diff​ (3.2 KB) - added by david.binda 11 months ago.

Download all attachments as: .zip

Change History (5)

@david.binda
11 months ago

#1 @mukesh27
11 months ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 6.4

Thanks @davidbinda for ticket and patch.

Patch tested on local and working fine. mark as commit consideration.

@costdev could you please take a look.

#2 @costdev
11 months ago

  • Owner set to costdev
  • Status changed from new to assigned

Thanks for the ticket @david.binda and for the ping @mukesh27!

59389.diff looks good!

Self-assigning for commit.

Last edited 11 months ago by costdev (previous) (diff)

#3 @costdev
11 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 56616:

Coding Standards: Replace PHP alias join() with implode().

In [52190], some new instances of the join() alias were introduced in the test suite.

Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.

This replaces the new join() uses with the canonical implode() function name.

Follow-up to [46182], [49193], [49805], [52190].

Props david.binda, mukesh27.
Fixes #59389.

#4 @costdev
11 months ago

  • Version set to 5.9
Note: See TracTickets for help on using tickets.