Get WordPress

Make WordPress Core

Opened 12 months ago

Closed 8 months ago

Last modified 8 months ago

#59200 closed defect (bug) (fixed)

Missing URL escape in wp-activate.php

Reported by: dilipbheda's profile dilipbheda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: coding-standards Cc:

Description

Found missing escape for continue button URL in wp-activate.php

Attachments (3)

59200.patch​ (735 bytes) - added by pitamdey 12 months ago.
After applying this solution the issue resolved
footer.patch​ (616 bytes) - added by nareshbheda 12 months ago.
I Found a missing escape in wp-includes/theme-compat/footer.php
59200.1.patch​ (1.3 KB) - added by pitamdey 9 months ago.
Updated Patch

Download all attachments as: .zip

Change History (9)

#2 @mukesh27
12 months ago

Thanks to @dilipbheda for the ticket and PR! 👏

Just a quick suggestion: Instead of having multiple separate tickets, could we consolidate everything into a single main ticket #58831? This will make it much easier to manage and keep track of. 📑

cc. @audrasjb

​@dilipbheda commented on ​PR #5090:
12 months ago #3

@mukeshpanchal27 I opened a new PR because I haven't found another issue like it and my previous PR is closed.
Do I need to create and submit a patch file to the ticket? and close this PR?

@pitamdey
12 months ago

After applying this solution the issue resolved

@nareshbheda
12 months ago

I Found a missing escape in wp-includes/theme-compat/footer.php

@pitamdey
9 months ago

Updated Patch

#4 @SergeyBiryukov
8 months ago

  • Milestone changed from Awaiting Review to 6.5

#5 @SergeyBiryukov
8 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57158:

Coding Standards: Add missing escaping in wp-activate.php.

Follow-up to [13884].

Props dilipbheda, mukesh27, pitamdey, nareshbheda.
Fixes #59200.

​@SergeyBiryukov commented on ​PR #5090:
8 months ago #6

Thanks for the PR! Merged in r57158.

Note: See TracTickets for help on using tickets.