Get WordPress

Make WordPress Core

Opened 12 months ago

Closed 11 months ago

Last modified 11 months ago

#59187 closed enhancement (fixed)

Bundled Themes need to be update to node 16

Reported by: jivygraphics's profile jivygraphics Owned by: desrosj's profile desrosj
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Build/Test Tools Keywords: good-first-bug has-patch needs-testing commit
Focuses: Cc:

Description

Supplied patch should be the package.lock file.

Change History (17)

#1 @desrosj
12 months ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Awaiting Review to 6.4

Related: #56658.

#2 follow-up: @whyisjake
12 months ago

twentynineteen might be fine. After a node 16 install/build no changes.

This ticket was mentioned in ​PR #5075 on ​WordPress/wordpress-develop by ​@mikestraw.
12 months ago #3

  • Keywords has-patch added; needs-patch removed

Updates twentynineteen package.json to Node 16.

Trac ticket: https://core.trac.wordpress.org/ticket/59187

#4 in reply to: ↑ 2 @mikestraw
12 months ago

Replying to whyisjake:

twentynineteen might be fine. After a node 16 install/build no changes.

I actually got changes: ​https://github.com/WordPress/wordpress-develop/pull/5075

Only three themes actually have a package.json:

find . -name package.json
./wp-content/themes/twentynineteen/package.json
./wp-content/themes/twentytwentyone/package.json
./wp-content/themes/twentytwenty/package.json

This ticket was mentioned in ​PR #5077 on ​WordPress/wordpress-develop by ​@mikestraw.
12 months ago #5

Updates twentytwenty package-lock.json to Node 16.

Trac ticket: https://core.trac.wordpress.org/ticket/59187

#7 in reply to: ↑ 6 @jivygraphics
12 months ago

Replying to mikestraw:

Created separate patches for each theme that has a package.json:

Mike! Thanks for pulling this!

This ticket was mentioned in ​PR #5078 on ​WordPress/wordpress-develop by ​@mikestraw.
12 months ago #8

Updates twentytwentyone package.json to Node 16.

Trac ticket: https://core.trac.wordpress.org/ticket/59187

This ticket was mentioned in ​Slack in #core by mikestraw. ​View the logs.
11 months ago

#10 @mikestraw
11 months ago

  • Keywords needs-testing added

#11 @desrosj
11 months ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to accepted

#12 @desrosj
11 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56531:

Bundled Themes: Use Node.js 16.x in themes with a build process.

This results in a new package-lock.json file being generated that uses lockfileVersion 2.x.

There are no changes to built files as a result of this update.

Follow up to [56378], [56387], [56442].

Props mikestraw, whyisjake, jivygraphics.
Fixes #59187. See #56658.

#13 @desrosj
11 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like another step is needed for Twenty Twenty and Twenty Twenty-One. It seems that npm install works but npm ci fails because of how peer dependencies are resolved in npm >= 7.0.0.

We'll need to add an .npmrc file with legacy-peer-deps = true, similar to what's in the main project folder now.

#14 @desrosj
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 56532:

Bundled Themes: Set legacy-peer-deps to true.

While npm install was working without issue after [56531], npm ci was not. The latter expects dependencies in the package-lock.json to match those in package.json exactly.

Follow up to [56378], [56387], [56442], [56531[.

Fixes #59187. See #56658.

Note: See TracTickets for help on using tickets.