Remove the Unused global variables in the wp-includes folder.

[upadalavipul]

I have reviewed the code and found Unused global variables in some of the below files. Please check the below files:

Files:

1. wp-includes/class-wp-xmlrpc-server.php
2. wp-includes/user.php

[upadalavipul]

Added patch

[upadalavipul]

need to removed one more file in unused global variable.

[SergeyBiryukov]

In 56477:

Users: Remove unused wpdb global in check_password_reset_key().

Follow-up to [45716].

Props upadalavipul.
See #59185.

[SergeyBiryukov]

In 56480:

XML-RPC: Remove unused wpdb global in wp_xmlrpc_server::mw_newMediaObject().

Follow-up to [2676], [4961], [5008], [24716], [34578].

Props upadalavipul.
See #59185.

[SergeyBiryukov]

Hi there, thanks for the patches!

Looking at 59185.2.patch​, I don't think those variables should be removed, as they are explicitly globalized for use in theme templates, and removing them would break backward compatibility. For reference, load_template() was introduced in [1910].

So I believe this is fixed by [56477] and [56480].

[SergeyBiryukov]

#59349 was marked as a duplicate.