Site Health: Escaped HTML in test label

[dlh]

The Site Health test for writeable backup directories added in [55720] includes a check for the wp-content directory path. When this test fails, the label for the result displays (<code>wp-content</code>), as these labels are HTML-escaped.

The linked PR would remove the HTML from the label. wp-content still appears in the result description, and keeping the directory name out of the label is still consistent with at least some of the other labels in the test, such as The temporary backup directory exists but is not writable.

[mukesh27]

Thanks @dlh for the ticket and PR. Look good to me and approved.

Added commit for consideration.

[mukesh27]

After patch

[audrasjb]

By default, $wp_content returns a path, like for instance /home/htdocs/wordpress/wp-content/. Not sure we should display the whole path in the description?

[SergeyBiryukov]

In 56117:

Site Health: Correct the label for wp-content directory check.

This removes HTML tags from the label, which were not displayed as expected due to escaping. Including the directory name in the label is also redundant, as it is already mentioned in the check result description directly below.

Includes:

• Adjusting a few other labels for consistency.
• Moving wp-content out of the translatable string in a similar message in WP_Upgrader::generic_strings().

Follow-up to [55720].

Props dlh, mukesh27, audrasjb, SergeyBiryukov.
See #58678.

Thanks for the PR! Merged in r56117.

[SergeyBiryukov]

Replying to audrasjb:

By default, $wp_content returns a path, like for instance /home/htdocs/wordpress/wp-content/. Not sure we should display the whole path in the description?

I might be missing something, but I don't see the full path displayed anywhere in the description, could you clarify? :)

[audrasjb]

Replying to SergeyBiryukov:

I might be missing something, but I don't see the full path displayed anywhere in the description, could you clarify? :)

My bad, I misunderstood the PR 🙃

[SergeyBiryukov]

Ah, no worries :)