block_core_navigation_submenu_build_css_colors function has been removed since 6.3 beta2

[manooweb]

This public function has been removed from the latest beta release without any deprecation.

The pull request that removed this function is ​https://github.com/WordPress/gutenberg/pull/48936

At the opposite of this other PR ​https://github.com/WordPress/gutenberg/pull/49064 where it is written a deprecation had to be done, it seems it wasn't the case.

So as we use this function in one of our block that we could insert as subblock navigation, we now have a php Fatal Error

[29-Jun-2023 10:45:40 UTC] PHP Fatal error: Uncaught Error: Call to undefined function block_core_navigation_submenu_build_css_colors()

Detected our PHPunit test in our side.

[sabernhardt]

This may need to be fixed in the plugin first, as [56098] was.

The function is gone, but the docblock remains. If the function should be deprecated instead of returning it where it had been, the since note would be WordPress 5.9.0 ([52069]).

[albatross10]

Hello @manooweb

To get this straight, I see that the doc block has also been removed. Now for the further work, do we have to bring back the function again and add a deprecation ?

[manooweb]

Hello @albatross10,

Yes! The goal is to avoid to have a PHP Fatal Error and leave enough time to plugins development team as us to fix by replacing by the wp_apply_colors_support() if I correctly understood.

Thanks.

[hugod]

Hi,
There is another problem regarding the function deletion.
Plugin can safely avoid using it in a new version.
But user may not update it just in time along WordPress 6.3 leading to fatal error (potentially on a lot of sites).

[manooweb]

Replying to sabernhardt:

This may need to be fixed in the plugin first, as [56098] was.

The function is gone, but the docblock remains. If the function should be deprecated instead of returning it where it had been, the since note would be WordPress 5.9.0 ([52069]).

Also reported in Gutenberg project ​https://github.com/WordPress/gutenberg/issues/52244 cc @audrasjb

[sabernhardt]

This could be fixed by changeset:56126

[manooweb]

Replying to sabernhardt:

This could be fixed by changeset:56126

Thank you.

[mukesh27]

This ticket was discussed during the bug scrub.

@manooweb The issue is now resolved. Mark ticket as invalid. feel free to reopen if you face the same issue. Thanks!

[manooweb]

Replying to mukesh27:

This ticket was discussed during the bug scrub.

@manooweb The issue is now resolved. Mark ticket as invalid. feel free to reopen if you face the same issue. Thanks!

Ok. I saw however changeset is not yet commited.

edit > Sorry I didn't see that the function was moved to wp-includes/deprecated.php 😴