Running remove_menu_page in the theme will cause admin-ajax.php 500 errors

[niau]

<?php
  add_action('admin_init', function () {
    current_user_can('administrator') || remove_menu_page('tools.php');
  });

When I log in with administrator, everything is fine, but when I switch to another user, I can't get into Media Manager.

Check the source code and find that '/wp-admin/includes/plugin.php' of 'remove_menu_page' does not check if '$menu' is empty.

<?php
  function remove_menu_page( $menu_slug ) {
    global $menu;

    if (!empty($menu)) {
      foreach ( $menu as $i => $item ) {
        if ( $menu_slug === $item[2] ) {
          unset( $menu[ $i ] );
          return $item;
        }
      }
    }


    return false;
  }

[petitphp]

Hello @niau and welcome to trac.

Looking at your example, you are calling the function remove_menu_page during the admin_init action.
According to ​the documentation for this function, you should be using the admin_menu action instead to avoid the error.
The admin_init action is too early, and the menu is not ready to be manipulated at this point.

Can you try to change the hook and see if you still have the issue ?

[niau]

Replying to petitphp:

Hello @niau and welcome to trac.

Looking at your example, you are calling the function remove_menu_page during the admin_init action.
According to ​the documentation for this function, you should be using the admin_menu action instead to avoid the error.
The admin_init action is too early, and the menu is not ready to be manipulated at this point.

Can you try to change the hook and see if you still have the issue ?

Thanks, switching to 'admin_menu' solved my problem.

[petitphp]

Thanks for the follow-up.

Closing the ticket.