Opened 15 months ago
Last modified 15 months ago
#58296 new enhancement
CSS coding standards issue in 'wp-activate.php'
| Reported by: |
monzuralam
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Networks and Sites | Keywords: | has-patch |
| Focuses: | css, multisite, coding-standards | Cc: |
Description
File path: src/wp-activate.php
Here CSS Coding Standards don't follow in Line 110.
Change History (3)
This ticket was mentioned in PR #4440 on WordPress/wordpress-develop by @monzuralam.
15 months ago
#1
- Keywords has-patch added; needs-patch removed
#2
follow-up:
↓ 3
@
15 months ago
- Component changed from General to Networks and Sites
- Focuses multisite added
- Version trunk deleted
Hello and thank you for the ticket!
I think these CSS rules were declared that way to avoid taking too much room in the screen's source code. Not sure it's worth changing this… I thought CSS Coding Standards primarily apply to .css files, not sure it applies on inline CSS as well.
By the way, I'm unsure why you replaced the declaration of one CSS selector and not the others?
#3
in reply to:
↑ 2
@
15 months ago
Replying to audrasjb:
Hello and thank you for the ticket!
I think these CSS rules were declared that way to avoid taking too much room in the screen's source code. Not sure it's worth changing this… I thought CSS Coding Standards primarily apply to .css files, not sure it applies on inline CSS as well.
By the way, I'm unsure why you replaced the declaration of one CSS selector and not the others?
Thanks, audrasjb
That time, I was confused about taking a decision that's why happened it.
I think we must follow Coding Standards Everywhere. ( It's my opinion )
Okay, I'll update my patch.
Trac ticket: [58296]