space showing as as URL encoded character after searching for plugin

[254volkan]

Screenshot here ​https://ibb.co/GnVj1kW

[dilipbheda]

Here is the patch to fix this issue.

[dilipbheda]

@254volkan Thank you for the ticket.

I Have reviewed this issue and fixed it with the attached patch.

It seems the issue created by the previous ticket: https://core.trac.wordpress.org/ticket/56339

Thanks

[audrasjb]

Introduced in [53844].

[audrasjb]

Hello @254volkan, welcome to WordPress Core Trac, and thanks for the ticket!

@dilipbheda thanks for the patch too, but this would revert [53844] which fixed an issue with some characters (see the related ticket). We need an implementation that doesn't revert that fix :)

[254volkan]

Hi @audrasjb
Yes, this is on 6.1.1 which is the most recent release

[audrasjb]

To clarify @254volkan I moved the Version information from 6.1.1 to 6.1 because this metadata is about the version that introduced the issue, not the version you reproduced the issue ;-)

[254volkan]

my bad

[adhun]

This patch will show the decode search keyword on plugins install page.

[adhun]

The above patch will show the url decoded string on plugin install page.
Also this #56339 issue is not coming back after applying the above patch.

[syamraj24]

After applying the patch plugin search page looks fine.

[syamraj24]

Also the pagination with special characters working fine as expected. #56339 issue is not getting reverted after applying the above patch.

[audrasjb]

After patch: looks great

[audrasjb]

This new patch looks good to me (see above screenshot). I'll add a PR just to make sure tests are passing well, then commit. Thanks.

https://core.trac.wordpress.org/ticket/57174

[audrasjb]

In 54904:

Plugins: Correctly display spaces in installed plugins search results.

This changeset improves searched terms URL decoding in installed plugins search results.

Follow-up to [53844].

Props 254volkan, dilipbheda, audrasjb, adhun, syamraj24.
Fixes #57174.

Committed in https://core.trac.wordpress.org/changeset/54904