oEmbed: Add support for Tumblr reader URLs

[pento]

We've supported Tumblr's blog network URLs since WP 4.2. Tumblr has since added a dashboard view, which WP currently doesn't support.

For example, ​this post embeds correctly, but ​the same post in the Tumblr dashboard doesn't embed.

[pento]

In 54393:

Embeds: Add support for Tumblr Dashboard URLs.

WordPress has supported embedding Tumblr blog network posts since 4.2.0. This commit adds support for embedding posts using Tumblr Dashboard URLs.

Fixes #56733.

[pento]

Re-opening this ticket, as the original fix was incorrect: Tumblr just changed their URL structure. 🙃

I think it's reasonable to change the behaviour to rely on Tumblr's oEmbed endpoint to tell us whether this is a valid embed URL or not. (For example, trying to ​embed the embed endpoint correctly returns an error.)

This brings Gutenberg and WordPress core behaviour into line (once ​GB44854 is merged).

[chaion07]

Thanks @pento for reporting this. We reviewed this during a recent bug-scrub session. Here's the summary of the feedback received from the team:

1. Adding keyword needs-testing as we feel that the ticket could benefit from some testing. Since this is a bug introduced during 6.1, it should probably be fixed. We are not as concerned with the GB PR not being merged yet.
2. We may just punt it and if that is the case then there is a chance that [54393] may also be reverted.
3. ​This Github Issue is also necessary. So folks from the Editor team should also weigh in.
4. There is an updated patch available for testing.
5. The Team finally decided to leave the ticket as is and possibly address after RC2 because it seems like a bug in the current implementation added in 6.1

Cheers!

Props to @desrosj @davidbaumwald @jorbin @jeffpaul @bernhard-reiter

[chaion07]

Updating ticket as this keyword was added mistakenly. Thanks!

[cbravobernal]

The editor part PR is working fine when applying this patch.

​https://github.com/WordPress/gutenberg/pull/44854#issuecomment-1283827792

[Bernhard Reiter]

I've tested the updated patch. Note that WordPress caches oEmbeds (in the corresponding post’s post meta), so we’re taking that into account in the following instructions.

On trunk:

• Create a new post.
• Switch to the Code Editor (this is to prevent oEmbed expansion in the Visual Editor, which is handled separately but might prime the cache).
• Insert two Tumblr URLs in separate formats, e.g.
  • ​https://photomatt.tumblr.com/post/696629352701493248/why-go-nuts-show-nuts-doesnt-work-in-2022 and
  • ​https://www.tumblr.com/photomatt/696629352701493248/why-go-nuts-show-nuts-doesnt-work-in-2022
• Do not switch back to the Visual Editor. Instead, publish the post directly from the Code Editor.
• View the post.

You should see the first URL properly expanded into the tumblr post’s oEmbed, but the second one un-expanded (just the URL).

• Write down the post ID. We’ll refer to it as YOUR_POST_ID in the following.
• In your terminal, verify that the post has oEmbed data cached in its post meta:

npm run env:cli post meta list YOUR_POST_ID

• You should see a post meta table with a few entries starting with _oembed_. Something like

+---------+-----------------------------------------------+------------------------------------------------------------------------------------------+
| post_id | meta_key                                      | meta_value                                                                               |
+---------+-----------------------------------------------+------------------------------------------------------------------------------------------+
| 45      | _edit_lock                                    | 1666213351:1                                                                             |
| 45      | _oembed_1c805202e7bc7384a18e9127ac66fc0a      | <div class="tumblr-post" data-href="https://embed.tumblr.com/embed/post/vmmie3u7VrfQyfsJ |
|         |                                               | WrijkQ/696629352701493248" data-did="5d8c0d3a24e12f917cd50640525f7785fc206836"  ><a href |
|         |                                               | ="https://photomatt.tumblr.com/post/696629352701493248/why-go-nuts-show-nuts-doesnt-work |
|         |                                               | -in-2022">https://photomatt.tumblr.com/post/696629352701493248/why-go-nuts-show-nuts-doe |
|         |                                               | snt-work-in-2022</a></div><script async src="https://assets.tumblr.com/post.js"></script |
|         |                                               | >                                                                                        |
| 45      | _oembed_time_1c805202e7bc7384a18e9127ac66fc0a | 1666213194                                                                               |
| 45      | _oembed_897442790bd8799408ee0d764e295748      | {{unknown}}                                                                              |
+---------+-----------------------------------------------+------------------------------------------------------------------------------------------+

• Now delete that post meta:

  npm run env:cli "post meta delete YOUR_POST_ID --all".
  

• Apply the patch.
• Reload the post on the frontend.

Verify that this time around, both URLs expand into their corresponding oEmbeds.

[pento]

In 54652:

Embeds: Broaden the Tumblr oEmbed matcher to include all Tumblr URL structures.

Tumblr's oEmbed API correctly rejects invalid URLs, we can rely on that for the handful of cases that aren't embeddable URLs.

Props cbravobernal, bernhard-reiter.
Fixes #56733.

[pento]

In 54653:

Embeds: Broaden the Tumblr oEmbed matcher to include all Tumblr URL structures.

Tumblr's oEmbed API correctly rejects invalid URLs, we can rely on that for the handful of cases that aren't embeddable URLs.

Props cbravobernal, bernhard-reiter.
Merges [54652] to the 6.1 branch.
Fixes #56733.