Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53926 closed defect (bug) (fixed)

Make capitalization of 'web host' consistent in setup messages

Reported by: bradparbs's profile bradparbs Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch commit
Focuses: ui-copy Cc:

Description

In the rest of core, 'web host' is used, but for one message in setup-config.php, 'Web Host' is used.

This patch makes it so we're consistent everywhere now.

Attachments (3)

53926-fix-web-host-capitilization.patch​ (831 bytes) - added by bradparbs 3 years ago.
53926-fix-web-host-capitilization-2.patch​ (831 bytes) - added by bradparbs 3 years ago.
53926-fix-web-host-capitilization-3.patch​ (830 bytes) - added by bradparbs 3 years ago.
oops

Download all attachments as: .zip

Change History (7)

@bradparbs
3 years ago

#1 @sabernhardt
3 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.9

Good catch! However, it seems this patch tries to capitalize the words on line 195 instead of changing them to lowercase.

@bradparbs
3 years ago

@bradparbs
3 years ago

oops

#2 @bradparbs
3 years ago

Originally generated the patch backwards 🤦️ and then typoed it in a second patch 🤦️

Ignore patch #⁠2, #⁠3 is actually the correct one

Last edited 3 years ago by bradparbs (previous) (diff)

#3 @mukesh27
3 years ago

  • Keywords commit added; needs-refresh removed

53926-fix-web-host-capitilization-3.patch​ looks fine now. Marking for commit.

#4 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51610:

Upgrade/Install: Use consistent capitalization for "web host" in setup messages.

Follow-up to [8887], [13163].

Props bradparbs, sabernhardt, mukesh27.
Fixes #53926.

Note: See TracTickets for help on using tickets.