Duplicate inline JS

[malthert]

in /wp-includes/class.wp-scripts.php

public function __construct() {
    $this->init();
    add_action( 'init', array( $this, 'init' ), 0 );
}

calls the init twice which leads to include the script twice as action

do_action_ref_array( 'wp_default_scripts', array( &$this ) );

Which then ends up with

<script id='lodash-js-after'>
window.lodash = _.noConflict();
window.lodash = _.noConflict();
</script>

on frontend.

This affects all scripts that use add inline script, basically bloating the frontend.

[malthert]

Update: it's not only bloating the frontend, in some cases (like the above example) it will cause js console errors making the site unusable

[desrosj]

Hi @malthert,

I have not been able to reproduce the behavior you are describing.

Do you have any plugins active? Are you testing on a default theme? Are there any steps someone needs to take in order to see this happening?

[SergeyBiryukov]

This could probably use a comment explaining the reason for double initialization.

Some history here:

• [19865] / #19959
• [19872] / #19959
• [21132] / #20971

[malthert]

Issue fixed itself now. Problem was something else, but I can't remember what exactly.

[kkmuffme]

This happens when registering/enqueuing a script on a hook before init OR on init with priority < 0

There currently is a "doing_it_wrong" when using any hook before init already, however this doing_it_wrong won't trigger if a script is enqueued on init with priority < 0
(e.g. add_action( 'init', 'foo', -10 );)