Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53422 closed defect (bug) (fixed)

Bundled Themes: Minor styling issues with blocks in widget areas

Reported by: noisysocks's profile noisysocks Owned by: ryelle's profile ryelle
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch
Focuses: Cc:

Description

Some of the WordPress bundled themes have minor styling issues when there are blocks in a widget area.

  • Twenty Twenty-one: Headings in Latest Posts block are too large.

https://cldup.com/i11VsHkl6y-2000x2000.png

  • Twenty Seventeen: Extra padding in Latest Comments block.

https://cldup.com/HaTONXih_B-3000x3000.png

  • Twenty Sixteen: Extraneous separator above Latest Comments block.

https://cldup.com/UjhZvmhFqj-3000x3000.png

  • Twenty Fourteen: Text has low contrast in Latest Comments block.

https://cldup.com/olAhD2PMvZ-3000x3000.png

  • Twenty Thirteen: Extra padding in Latest Comments block.

https://cldup.com/x9PZjw7ua8-3000x3000.png

  • Twenty Ten: Extra padding on left of Latest Posts block.

https://cldup.com/UVNFHfHW4e-3000x3000.png

Attachments (2)

53422.diff (3.2 KB) - added by sumaiyasiddika 3 years ago.
Fixed minor styling issues with blocks in widget area
53422.2.diff (6.8 KB) - added by danieldudzic 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @desrosj
3 years ago

  • Keywords needs-patch has-screenshots added

@sumaiyasiddika
3 years ago

Fixed minor styling issues with blocks in widget area

#2 @sumaiyasiddika
3 years ago

  • Keywords has-patch added; needs-patch removed

@danieldudzic
3 years ago

#3 @danieldudzic
3 years ago

Adding this, since I started working on it before the original patch was created. I believe my diff is a bit more comprehensive.

#4 @scruffian
3 years ago

I don't see the TT1 issue when running the latest Gutenberg plugin, maybe some these things were fixed in Gutenberg?

#5 @jffng
3 years ago

Thank you @sumaiyasiddika and @danieldudzic for the patches.

I tested 53422.2.diff and it fixes most all of the issues. The only one I can't verify is the removal of the extraneous separator in Twenty Sixteen.

Here are screenshots:

  • Twenty Twenty-One, latest posts size looks correct

https://cldup.com/8tTXcGJAcJ.png

  • Twenty Seventeen, extra padding is fixed

https://cldup.com/nsLrI6F_8y.png

  • Twenty Sixteen, not sure if the extra separator is fixed or if padding is correct

https://cldup.com/EVpjjMCnBe.png

  • Twenty Fourteen, text contrast is fixed

https://cldup.com/6TBUh-SX3f.png

  • Twenty Ten, padding is fixed

https://cldup.com/PBZuMWB_hM.png

Last edited 3 years ago by jffng (previous) (diff)

#6 @ryelle
3 years ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 51205:

Bundled Themes: Improve display of blocks in widget areas.

Fixes minor styling issues, mostly font size and spacing, in blocks used in widget areas. Changes made to Twenty Ten, Twenty Thirteen, Twenty Fourteen, Twenty Sixteen, Twenty Seventeen, and Twenty Twenty-One.

Props noisysocks, sumaiyasiddika, danieldudzic, scruffian, jffng.
Fixes #53422.

Note: See TracTickets for help on using tickets.