WordPress.org

In [47198], parentheses were removed from include and require statements, as they are language constructs, not function calls. However, [50161] introduced a new require_once instance in wp-admin/options-privacy.php. This change removes the unnecessary parentheses.

See #53627.

Last edited 3 years ago by davidbaumwald (previous) (diff)

#8 @davidbaumwald
3 years ago

In 50632:

Coding Standards: Remove some extra whitespace in get_item_schema.

Introduced in [50527].

See #52627.

#9 in reply to: ↑ 7 ; follow-up: ↓ 10 @mukesh27
3 years ago

@davidbaumwald Do we need to remove parentheses from here https://github.com/WordPress/WordPress/blob/master/wp-includes/class-requests.php#L146?

Replying to davidbaumwald:

In [50631]:

Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.

In [47198], parentheses were removed from include and require statements, as they are language constructs, not function calls. However, [50161] introduced a new require_once instance in wp-admin/options-privacy.php. This change removes the unnecessary parentheses.

See #53627.

#10 in reply to: ↑ 9 @davidbaumwald
3 years ago

Replying to mukesh27:

@davidbaumwald Do we need to remove parentheses from here https://github.com/WordPress/WordPress/blob/master/wp-includes/class-requests.php#L146?

Replying to davidbaumwald:

In [50631]:

Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.

In [47198], parentheses were removed from include and require statements, as they are language constructs, not function calls. However, [50161] introduced a new require_once instance in wp-admin/options-privacy.php. This change removes the unnecessary parentheses.

See #53627.

@mukesh27 Good catch, but that's one of the third-party library exclusions. See https://core.trac.wordpress.org/browser/tags/5.7/phpcs.xml.dist#L116

#11 @mukesh27
3 years ago

@davidbaumwald Thanks for the information.

https://github.com/WordPress/WordPress/commits/master/wp-includes/class-requests.php

If you check GitHub history for that file then you found that core developer's changed some code as per new possible updates.

#12 @SergeyBiryukov
3 years ago

In 50652:

Coding Standards: Use strict comparison in wp-admin/includes/class-core-upgrader.php.

See #52627.

#13 @SergeyBiryukov
3 years ago

In 50654:

Coding Standards: Move some translator comments to the correct place.

Follow-up to [46273], [50060], [50117].

See #52627.

#14 @SergeyBiryukov
3 years ago

Since [50060] and [50117] were in 5.7, going to merge [50654] to the 5.7 branch too.

#15 @SergeyBiryukov
3 years ago

In 50655:

Coding Standards: Move some translator comments to the correct place.

Follow-up to [46273], [50060], [50117].

Merges [50654] to the 5.7 branch.
See #52627.

#16 @SergeyBiryukov
3 years ago

In 50657:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-filesystem-*.php.

See #52627.

#17 @SergeyBiryukov
3 years ago

In 50658:

Coding Standards: Give some variables in WP_Importer a more meaningful name.

See #52627.

#18 @SergeyBiryukov
3 years ago

In 50664:

Coding Standards: Use strict comparison in wp-admin/includes/comment.php.

See #52627.

#19 @SergeyBiryukov
3 years ago

In 50665:

Coding Standards: Use strict comparison in wp-admin/includes/credits.php.

See #52627.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.

3 years ago

#21 @SergeyBiryukov
3 years ago

In 50689:

Coding Standards: Use strict comparison in wp-admin/includes/dashboard.php.

Includes minor code layout fixes for better readability.

See #52627.

#22 @SergeyBiryukov
3 years ago

In 50696:

Coding Standards: Give a variable in wp-admin/themes.php a more meaningful name.

Follow-up to [20029].

See #52627.

#23 @SergeyBiryukov
3 years ago

In 50699:

Coding Standards: Simplify the check for parent terms in export_wp().

This is more consistent with similar checks elsewhere in core.

See #52627.

#24 @SergeyBiryukov
3 years ago

In 50700:

Coding Standards: Use strict comparison in wp-admin/includes/file.php.

Includes minor code layout fixes for better readability.

See #52627.

#25 @SergeyBiryukov
3 years ago

In 50701:

Coding Standards: Rewrite a fragment in request_filesystem_credentials() for clarity and to avoid repetition.

Follow-up to [8540], [8865].

See #52627.

#26 @SergeyBiryukov
3 years ago

In 50706:

Coding Standards: Use strict comparison in wp-admin/includes/class-custom-background.php.

Includes minor code layout fixes for better readability.

See #52627.

#27 @SergeyBiryukov
3 years ago

In 50707:

Coding Standards: Use strict comparison in wp-admin/includes/class-custom-image-header.php.

Includes minor code layout fixes for better readability.

See #52627.

#28 @SergeyBiryukov
3 years ago

In 50759:

Coding Standards: Give a variable in WP_Automatic_Updater::after_core_update() a more meaningful name.

Follow-up to [25841], [25873], [25882].

See #52627.

#29 @SergeyBiryukov
3 years ago

In 50762:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-automatic-updater.php.

Includes minor code layout fixes for better readability.

See #52627.

#30 @SergeyBiryukov
3 years ago

In 50767:

Coding Standards: Use strict comparison in wp-admin/includes/class-walker-nav-menu-edit.php.

See #52627.

#31 @SergeyBiryukov
3 years ago

In 50768:

Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-comments-list-table.php.

Rename method argument in WP_Comments_List_Table::floated_admin_avatar() per the naming conventions.
Use strict comparison in WP_Comments_List_Table::handle_row_actions().

See #52627.

#32 @SergeyBiryukov
3 years ago

In 50770:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-media-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

#33 @davidbaumwald
3 years ago

In 50779:

Coding Standards: Fix minor, inline spacing issue in wp-admin/setup-config.php.

See #52627.

#34 @SergeyBiryukov
3 years ago

In 50780:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-terms-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

#35 @SergeyBiryukov
3 years ago

In 50783:

Coding Standards: Remove loose comparison in wp-admin/includes/plugin-install.php.

This more closely represents how the active installations count is displayed in the Plugin Directory.

See #52627.

#36 @SergeyBiryukov
3 years ago

In 50785:

Coding Standards: Use strict comparison in wp-admin/includes/update-core.php.

Includes minor code layout fixes for better readability.

See #52627.

#37 @SergeyBiryukov
3 years ago

In 50795:

Coding Standards: Fix a precision alignment issue in wp-admin/includes/template.php.

Follow-up to [49223].

See #52627.

This ticket was mentioned in Slack in #core by sergey. View the logs.

3 years ago

#39 @SergeyBiryukov
3 years ago

In 50804:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-posts-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

#40 @SergeyBiryukov
3 years ago

In 50805:

Coding Standards: Fix a whitespace at end of line issue in wp-admin/includes/class-wp-comments-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

#41 @SergeyBiryukov
3 years ago

In 50832:

Coding Standards: Use strict comparison in wp-admin/includes/screen.php.

See #52627.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.

3 years ago

#43 @SergeyBiryukov
3 years ago

In 51047:

Coding Standards: Use strict comparison in wp-includes/class-wp-customize-nav-menus.php.

See #52627.

#44 @SergeyBiryukov
3 years ago

In 51070:

Coding Standards: Simplify the logic in WP_Widget::get_field_name() and ::get_field_id().

Includes minor code layout fixes for better readability.

Follow-up to [41292], [50953], [50961].

Props 5ubliminal, solarissmoke, tamlyn, jdgrimes, jorbin, stevenkword, drebbits.web, westonruter, jipmoors, justinahinon, helen, lukecarbis, Mte90, hellofromTonya, SergeyBiryukov.
See #16773, #52627.