Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#49316 closed defect (bug) (fixed)

Twenty Twenty missed license for images.

Reported by: h71's profile h71 Owned by: ianbelanger's profile ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: commit has-patch fixed-major
Focuses: Cc:

Description

Used images in the Twenty Twenty theme are not listed with license information in the readme file. This is a requirement based on theme review team comments.

This is important as many theme developers are using default themes as a standard convention.

Attachments (1)

49316.patch​ (528 bytes) - added by poena 4 years ago.
updated image credits

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
5 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Tweny Tweny missed license for images. to Twenty Twenty missed license for images.

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

Just adding links to previous similar tickets here:

#2 @ianbelanger
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.4
  • Type changed from enhancement to defect (bug)
  • Version set to 5.3

Adding this to 5.4 milestone as it is a simple fix.

#3 @poena
5 years ago

Hi

The theme review team did indeed talk about this on Slack but can you specify exactly which images?
The illustrations that are in the assets/images folder are already mentioned in the readmefile.

Last edited 5 years ago by poena (previous) (diff)

#4 @h71
5 years ago

Hi, I see the term

Illustrations in screenshot.png ...

But not all of the illustrations are used in the screenshot.png

#5 @ianbelanger
4 years ago

  • Keywords 2nd-opinion added; needs-patch removed
  • Milestone changed from 5.4 to Future Release

Punting this out of 5.4 as it needs more feedback.

@poena
4 years ago

updated image credits

#6 @ianbelanger
4 years ago

  • Keywords commit has-patch added; 2nd-opinion removed
  • Milestone changed from Future Release to 5.5
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Reviewing for commit

#7 @ianbelanger
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47608:

Bundled Themes: Twenty Twenty missed license for images.

Fixes the image license in the readme by removing screenshot.png.

Props h71, poena.
Fixes #49316.

#8 @ianbelanger
4 years ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#9 @whyisjake
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47827:

Bundled Themes: Twenty Twenty missed license for images.
Fixes the image license in the readme by removing screenshot.png.

Brings the changes from [47608] to the 5.4 branch.

Props h71, poena.
Fixes #49316.

Note: See TracTickets for help on using tickets.