Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#44633 closed defect (bug) (fixed)

Commented out code in class-wp-customize-nav-menus.php

Reported by: harsh175's profile harsh175 Owned by: drewapicture's profile DrewAPicture
Milestone: 5.1 Priority: normal
Severity: minor Version: 4.3
Component: Customize Keywords: has-patch commit
Focuses: docs Cc:

Description

I found commented out code in /wp-includes/class-wp-customize-nav-menus.php

These actions are no longer available anywhere.

As consider coding standards we should remove the unused actions from the file.

Attachments (2)

44633.patch​ (485 bytes) - added by harsh175 6 years ago.
44633.2.patch​ (905 bytes) - added by dlh 6 years ago.

Download all attachments as: .zip

Change History (7)

@harsh175
6 years ago

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Customize

@dlh
6 years ago

#2 @dlh
6 years ago

  • Version changed from trunk to 4.3

44633.2.patch​ amends the original patch slightly to keep the "todo" itself, which, I think, is still relevant.

#3 @westonruter
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.0

#4 @SergeyBiryukov
6 years ago

  • Milestone changed from 5.0 to 5.1

#5 @DrewAPicture
6 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 44328:

Customizer: Remove a line of commented-out code in WP_Customize_Nav_Menus::customize_register().

Retains a more explicit future-compat version of the todo notation that used to accompany the commented-out code.

Props harsh175, dlh.
Fixes #44633.

Note: See TracTickets for help on using tickets.