User list table admin: Need to replace blank space with "—" when first_name and last_name is blank

[Girishpanchal]

When the user doesn't enter their first name and last name, admin panel the user listing page has listed blank space instead of "—" "Name" column like page listing. I have attached the screenshot for more clarification.
​http://www.awesomescreenshot.com/image/2451426/6ea3628ba681f70e587594748a9147d8

[afercia]

@Girishpanchal thanks for your patch, makes sense to me! Ideally this should be implemented as in the other list tables, hiding the dash to assistive technologies and adding some hidden screen reader text. See for example:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-posts-list-table.php?rev=40361#L1124
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-list-table.php?rev=40361#L659

In this case, the hidden text could be something like No name?

[Girishpanchal]

@afercia Can we use "Unknown" instead of "No name"?. Please let me know your thought then i will update patch for same.

Also i have found post category listing page where description is empty/blank.
​http://www.awesomescreenshot.com/image/2455447/e13c74d4c1489ff1f6806c4a0b7aac42

I will add another patch for the category description column.

Thank you

[afercia]

"Unknown" makes sense to me and maybe it's even better. Screen readers already announce the column header "Name" so I'd say that hearing "Name ... unknown" is better than "Name ... No name" :)

Maybe such a string would need to give some context to translators though, so I'd consider to use _x().

Also i have found ...

Yep nice catch! Would you mind to open a separate ticket for that, please? It's always preferable to to keep things separated.

[Girishpanchal]

Here, I have attached the patch for user listing table according to your suggestion.

Please check and let me know!

I will open new ticket for the post category description and will update patch for same.

[Girishpanchal]

Updated patch for class-wp-user-list-table.php

[afercia]

For reference: ​https://developer.wordpress.org/reference/functions/_x/

[afercia]

The same should be done for the wp-admin/network/users.php screen on multisite, see:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php?rev=40310#L260

[Girishpanchal]

Thank you for suggestion let me update patch for multisite !!

[Girishpanchal]

Updated patch for multi-site.

[afercia]

See also #40659.

[yahil]

@afercia I have made changes on existing .path to improve coding standard.

Solve phpcs notice:

1. Whitespace found at end of line
2. expected 1 space before/after closing bracket [ _x( 'Unknown' ); ]

[SergeyBiryukov]

In 40956:

Administration: In user list tables, display a dash instead of a blank space and add "Unknown" as a screen reader text when the user's first name and last name are blank.

Props Girishpanchal, yahil.
Fixes #40628.