Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#40448 closed defect (bug) (fixed)

Semantic elements for non-link links: edit-form-advanced.php

Reported by: cheffheid's profile Cheffheid Owned by: afercia's profile afercia
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Editor Keywords: semantic-buttons has-patch has-screenshots commit
Focuses: accessibility Cc:

Description

The "Get Shortlink" link should be a button. Since the slug and the form this button is part of disappear when JavaScript is disabled, it should suffice to just change it to that and call it a day.

Related: #26504.

Attachments (2)

40448.patch​ (942 bytes) - added by Cheffheid 7 years ago.
Swap out a tag with a button tag.
40448.diff​ (941 bytes) - added by afercia 7 years ago.

Download all attachments as: .zip

Change History (7)

@Cheffheid
7 years ago

Swap out a tag with a button tag.

#1 @Cheffheid
7 years ago

  • Keywords semantic-buttons has-patch added

#2 @rianrietveld
7 years ago

  • Milestone changed from Awaiting Review to 4.8

#3 @afercia
7 years ago

  • Version trunk deleted

Worth noting as of WordPress 4.4 the Get Shortlink button is hidden by default but can be restored via filters.

https://cldup.com/bhcNrNwgyw.png

@afercia
7 years ago

#4 @afercia
7 years ago

  • Component changed from Administration to Editor
  • Keywords has-screenshots commit added

Refreshed patch.

#5 @afercia
7 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 40578:

Accessibility: Make the Get Shortlink button be a real button.

Worth noting, as of WordPress 4.4, the Get Shortlink button is hidden by default
but it can be restored via filters.

Props Cheffheid.
See #26504.
Fixes #40448.

Note: See TracTickets for help on using tickets.