Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#38787 closed defect (bug) (fixed)

Add line-height to new customizer shortcut pencil icons

Reported by: jbobich's profile jbobich Owned by: westonruter's profile westonruter
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

Not a huge deal, but if a theme is styling general buttons (as many themes are) any declared line-height will affect the new shortcut pencil icons in the customizer, possibly making them look a bit off. This is because no line-height is specified on these shortcut pencil icons.

I'm referring to specifically:

.customize-partial-edit-shortcut button, 
.widget .customize-partial-edit-shortcut button {
	...
}

... in wp-includes/css/customize-preview.css.

Simply declaring a line-height there would fix this, for a more consistent customizer experience with this great, little new feature.

Apologies, if I'm not explaining clearly. See attached screenshot.

Attachments (2)

Screen Shot 2016-11-14 at 11.57.02 AM.png​ (509.6 KB) - added by jbobich 8 years ago.
Screenshot showing issue
38787.0.diff​ (383 bytes) - added by westonruter 8 years ago.

Download all attachments as: .zip

Change History (6)

@jbobich
8 years ago

Screenshot showing issue

#1 @westonruter
8 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to westonruter
  • Status changed from new to accepted

@westonruter
8 years ago

#2 @westonruter
8 years ago

  • Keywords has-patch added

@sirbrillig here's another instance of !important being added. Any feedback from you here?

#3 @westonruter
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 39242:

Customize: Add !important line-height to edit shortcut buttons.

Ensure that icon inside edit shortcut is centered when theme defines default line-height for button elements.

Fixes #38787.

#4 @sirbrillig
8 years ago

👍 Sorry for the delay! I was traveling yesterday.

Note: See TracTickets for help on using tickets.