Opened 10 years ago
Last modified 8 months ago
#27747 new defect (bug)
Inconsistent type default between `submit_button()` and `get_submit_button()`
| Reported by: |
Denis-de-Bernardy
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | 3.5 |
| Component: | Administration | Keywords: | has-patch dev-feedback |
| Focuses: | administration, template | Cc: |
Description
One defaults to $type = 'primary' while the other defaults to $type = 'primary large'.
Shouldn't that last one be $type = 'primary' too?
Attachments (1)
Change History (7)
@
#3
@
10 years ago
- Keywords has-patch 2nd-opinion added
Patch attached,
I checked the usage of get_submit_button function throughout the WP code and $type parameter is specified in each, so this change would not affect the WP admin.
The only side effect of this change is that button class would change in plugins/themes that count on 'primary large' to be a default, but I would say consistency between functions is more important.
@
#5
follow-up:
↓ 6
@
8 years ago
As you can see on https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/template.php#L1906 that patch already exist (https://core.trac.wordpress.org/ticket/27747#comment:2) in the last version of wordpress.
I think that ticket can be closed.
#6
in reply to:
↑ 5
@
8 months ago
- Milestone set to Awaiting Review
Replying to Mte90:
As you can see on https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/template.php#L1906 that patch already exist (https://core.trac.wordpress.org/ticket/27747#comment:2) in the last version of wordpress.
No, $type still defaults to 'primary' in submit_button() and 'primary large' in get_submit_button().
The ticket is still valid.
Introduced in [22099].