Incorrect call to `mysqli_fetch_field()`

[Denis-de-Bernardy]

We call it with two parameters, whereas it only expects a single one:

​http://us2.php.net/manual/en/mysqli-result.fetch-field.php

This breaks $wpdb->col_info among other things.

[pento]

Nice catch. :-)

As we're retrieving fields sequentially, we don't really need the field offset, anyway.

[Denis-de-Bernardy]

Quick aside, here: is there any good reason to silence errors in those calls the way things are, instead of ensuring that it won't spit out a warning?

[SergeyBiryukov]

Introduced in [27250].

[nacin]

In 28002:

wpdb: Don't pass a second argument to mysqli_fetch_field().

props pento.
fixes #27693.

[pento]

Replying to Denis-de-Bernardy:

Quick aside, here: is there any good reason to silence errors in those calls the way things are, instead of ensuring that it won't spit out a warning?

Good question! This has always existed, so I'm going to go with "no-one has been brave enough to change it".

[nacin]

#21870