Dubious code flow in add_metadata()

[Denis-de-Bernardy]

The code goes:

	$result = $wpdb->insert( $table, array(
		$column => $object_id,
		'meta_key' => $meta_key,
		'meta_value' => $meta_value
	) );

	if ( ! $result )
		return false;

	$mid = (int) $wpdb->insert_id;

	wp_cache_delete($object_id, $meta_type . '_meta');

If $result up there is false, it probably means the key exists in the database. In other words, the cache is stale.

Should be:

	$result = $wpdb->insert( $table, array(
		$column => $object_id,
		'meta_key' => $meta_key,
		'meta_value' => $meta_value
	) );

	wp_cache_delete($object_id, $meta_type . '_meta');

	if ( ! $result )
		return false;

	$mid = (int) $wpdb->insert_id;

[nacin]

I'm not sure. add_metadata() doesn't do any cache fetching or setting operations. The issue would be that a race between two add_metadata() calls would cause the second one to fail. At that point, the DB and cache should still be the same.

[hellofromTonya]

Thinking it's safe to close this ticket as wontfix. If it was causing a cache stale issue, I'd expect more reports and activity in this ticket. But given it's been 9 years with no activity (other than setting it to close), seems safe to close it.

However, if the issue persists today, then please reopen for further investigation.