Move browser_search_discovery.js and browser_addKeywordSearch.js to browser/components/search
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: standard8, Assigned: u682976, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
I just noticed that in browser/base/content/test/general/, we have browser_search_discovery.js and browser_addKeywordSearch.js.
We should move those across to browser/components/search as I think that's more appropriate (especially for the search discovery).
|
Reporter | |
Comment 1•3 years ago
|
||
I'm happy to mentor this. The basic work that needs to be done here:
hg mvthe two test files frombrowser/base/content/test/general/tobrowser/components/search/test/browser/.hg mvthe support file as wellbrowser/base/content/test/general/discovery.html- Move the references for the test and support files from
browser/base/content/test/general/browser.initobrowser/components/search/test/browser/browser.ini(to equivalent places, please keep alphabetical ordering) - Update the file
discovery.htmlreference inbrowser_search_discovery.js. - In
browser_addKeywordSearch.jschange theTEST_URLreference tohttp://example.org/browser/browser/components/search/test/browser/test.html - Do a build (
./mach build) - Make sure the tests pass in the new location (
./mach mochitest browser/components/search/test/browser/)
|
|
Reporter | |
Comment 3•3 years ago
|
||
Hi Dawit, sure. Issues will also be automatically assigned when the first patch is posted, but I'll set you as assignee anyway for this. Please let us know if you happen to stop working on it so we can reassign.
What passes as a success when I run the test command (./mach mochitest browser/components/search/test/browser/)?
I finished all the tasks and when I run that command, it opens up Firefox with 4 tabs and it crashes.
|
|
Reporter | |
Comment 5•3 years ago
|
||
(In reply to Dawit from comment #4)
What passes as a success when I run the test command (
./mach mochitest browser/components/search/test/browser/)?
I finished all the tasks and when I run that command, it opens up Firefox with 4 tabs and it crashes.
Normally there should be a success/fail indication at the end of the run. Maybe try it without your changes (commit the changes, then update to the current tip and rebuild), and see if that helps.
If you're still hitting issues, then the #introduction channel on Matrix is a good place to ask for help.
I just submitted a patch to Phabricator (https://phabricator.services.mozilla.com/D111944)
|
|
Reporter | |
Comment 8•3 years ago
|
||
Thank you - the patch is looking good, though there's an extra added file testing/web-platform/tests/websockets/Create-verify-url-set-non-default-port.any.js-53d60826 - please can you remove that? It shouldn't be necessary.
I'd normally comment on the patch itself, but as it is in draft mode, you wouldn't get notified of the comments. For the reviewer, you can request review from me, e.g. add "r=Standard8" in the commit message and re-submit (After also having removed the extra file).
|
||
Updated•3 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e82b7fa25ac9 Move some test files to their respective locations. r=Standard8
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
Description
•