Closed Bug 1698510 Opened 3 years ago Closed 3 years ago

Log the version of the loaded RNP library to the console

Categories

(MailNews Core :: Security: OpenPGP, enhancement)

Product:
MailNews Core
Component:
Security: OpenPGP
Type:
enhancement

Tracking

(thunderbird_esr78 fixed)

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed

People

(Reporter: justus, Assigned: justus)

Details

Attachments

(1 file, 1 obsolete file)

1698510-v2.patch
2.62 KB, patch
KaiE
: review+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review
Attached patch display-openpgp-version.diff (obsolete) — — Splinter Review

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

For accurate bug reports, Thunderbird should display the version of the OpenPGP library loaded. I'll attach a patch to that effect.

Could you provide screenshots of how it looks now and how it looks with this patch?

This message is written to the console. Without the patch, it says something like:

Successfully loaded OpenPGP library librnp.so from /var/tmp/thunderbird/obj-x86_64-pc-linux-gnu/dist/bin/librnp.so

With it it says something like:

Successfully loaded OpenPGP library librnp.so version X.Y.Z from /var/tmp/thunderbird/obj-x86_64-pc-linux-gnu/dist/bin/librnp.so

Thanks for the patch. I think we shouldn't declare functions twice. We can move the console.debug statement to avoid it.

Assignee: nobody → justus
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch 1698510-v2.patch — — Splinter Review

Justus, does this modified version look ok to you?

That looks much nicer indeed.

Attachment #9209110 - Attachment is obsolete: true

Comment on attachment 9214385 [details] [diff] [review]
1698510-v2.patch

r=kaie

I'll take care of landing.

Attachment #9214385 - Flags: review+
Summary: Patch to display the backend library version → Log the version of the loaded RNP library to the console

Thanks!

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/31e68de2d48c
Log the version of the loaded RNP library to the console. r=kaie

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
status-thunderbird_esr78: --- → affected
Target Milestone: --- → 89 Branch

Comment on attachment 9214385 [details] [diff] [review]
1698510-v2.patch

This will be useful for diagnosis, and cannot hurt on the stable branch.

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: less runtime diagnosis
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low

Attachment #9214385 - Flags: approval-comm-esr78?

Comment on attachment 9214385 [details] [diff] [review]
1698510-v2.patch

[Triage Comment]
Approved for esr78

Attachment #9214385 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.