Closed Bug 1698401 Opened 3 years ago Closed 3 years ago

Seeking to non-round number causes all WebVTT cues to fire between currentTime and seekTime.

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Version:
Firefox 87
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: robert.bryer, Assigned: robert.bryer)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Bug 1698401 - don't give PositionUpdate::ePeriodicUpdate when seeking, stopping timeMarchesOn() happening for a seek; set mLogicalPosition to the same as the seek target, so there's no inconsistency. r=alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1698401 - fix formatting, fix const; add wpt for onenter handler for seeking onto a cue
48 bytes, text/x-phabricator-request
Details | Review
Bug 1698401 - Remove stray console.log
48 bytes, text/x-phabricator-request
Details | Review
Bug 1698401 - don't give PositionUpdate::ePeriodicUpdate when seeking, stopping timeMarchesOn() happening for a seek; add wpt for checking correct onenter fires on seek r=alwu
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Seeking to a target with a fractional part on the number causes all WebVTT cues over the seek interval to call their 'enter' events.

Example:
http://smp-scratch.tools.bbc.co.uk/bob/plain.html

  1. Hit the +20 button to seek to currentTime += 20 + Math.rand()
  2. See in the console that all cues over the time are logged.

It won't happen if you use the controls seekbar or if you seek with a whole number.

Actual results:

All WebVTT cues between currentTime and seekTime fire.

Expected results:

Only cues active at these times fire.

Assignee: nobody → robert.bryer

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Blocks: webvtt

Depends on D108863

Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa184a5e26d1
don't give PositionUpdate::ePeriodicUpdate when seeking, stopping timeMarchesOn() happening for a seek; add wpt for checking correct onenter fires on seek r=alwu
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28405 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/fa184a5e26d1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.