Relative paths to DTD/xhtml1-strict.dtd lead to broken network loads
Categories
(Toolkit :: General, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: rai.ankur0007, Mentored)
References
()
Details
(Keywords: good-first-bug, helpwanted, Whiteboard: [lang=html], [wptsync upstream])
Attachments
(1 file)
In bug 1695247 we started collecting data on errors in network loads.
The top DTD error loads in Beta are:
omni.ja!/chrome/toolkit/content/global/DTD/xhtml1-strict.dtd
(Beta: volume: 3,776/day, clients: 3,214/day)omni.ja!/chrome/devtools/content/memory/DTD/xhtml1-strict.dtd
(Beta: volume: 1,482/day, clients: 1,424/day)
Scanning our source we can see a number of relative paths in XHTML documents: https://searchfox.org/mozilla-central/search?q=%22DTD%2Fxhtml1-strict.dtd&case=true&path=
In particular the devtools/client/memory/index.xhtml
seems like it could lead to the second of the loads (/memory/
in the path).
We should turn them into absolute URLs and maybe also be more vocal about broken DTD loads in browser console.
Comment 1•4 years ago
|
||
Zibi, thanks for filing this. Any recommendation for next triage owner? Should this go to Necko?
Reporter | ||
Comment 2•4 years ago
|
||
Distributed, unless we find someone who can do a sweep:
- browser/ - Firefox front-end team?
- devtools/ - Devtools team - https://wiki.mozilla.org/Modules/All#DevTools
- toolkit/ - Mossop, Gijs
Comment 3•4 years ago
|
||
Since according to the description toolkit is hit the most often, lets get it over there and see how they want to address this (create a new bug on their end, ...).
Comment 4•3 years ago
|
||
It looks like this is mostly a search&replace that needs to be done. This could probably be a mentored bug, Mark would you like to mentor it?
Comment 5•3 years ago
|
||
I'm happy to mentor this.
If you need help getting started, please see this document.
The work here is to replace references to "DTD/xhtml1-strict.dtd"
with "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"
These are the files affected:
https://searchfox.org/mozilla-central/search?q=%22DTD%2Fxhtml1-strict.dtd&case=true&path=
Reporter | ||
Updated•3 years ago
|
Comment 6•3 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #5)
I'm happy to mentor this.
If you need help getting started, please see this document.
The work here is to replace references to
"DTD/xhtml1-strict.dtd"
with"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"
These are the files affected:
https://searchfox.org/mozilla-central/search?q=%22DTD%2Fxhtml1-strict.dtd&case=true&path=
Hey I am new to Open Source and currently learning Web Development. Can I work on this issue?
I've gone through the document provided by @Mark Banner. Looks like the cloning part will take time. If this issue is for the new comers I would like to peek into it.
What I understood from the bug is: I have to replace the "DTD/xhtml1-strict.dtd"
with http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
in the files.
Comment 7•3 years ago
|
||
(In reply to divyanshusoni52 from comment #6)
Hey I am new to Open Source and currently learning Web Development. Can I work on this issue?
I've gone through the document provided by @Mark Banner. Looks like the cloning part will take time. If this issue is for the new comers I would like to peek into it.
Sure please start working on it. When you attach a patch, it'll automatically be assigned.
The cloning is likely to be the longest part, but once you've cloned once you shouldn't need to do that again for other bugs.
What I understood from the bug is: I have to replace the
"DTD/xhtml1-strict.dtd"
withhttp://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
in the files.
Almost correct, replace "DTD/xhtml1-strict.dtd"
with "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"
- the quotes were missing in the second case.
Comment 9•3 years ago
|
||
Hi achmurali, let's just check with divyanshusoni52 to see if they are still working on it.
Assignee | ||
Comment 10•3 years ago
|
||
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52b26c06e1f6 Replaced DTD/xhtml1-strict.dtd which lead to broken network loads. r=mossop
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28218 for changes under testing/web-platform/tests
Updated•3 years ago
|
Comment 13•3 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #9)
Hi achmurali, let's just check with divyanshusoni52 to see if they are still working on it.
Sorry for the late reply. I tried to clone the repo but I think I won't be able to continue with this issue. I am having some serious issues with my system. It can't handle such large files as of now. I'll get back to the org and contribute as soon as I update my machine. Thank you.
Comment 14•3 years ago
|
||
bugherder |
Upstream PR was closed without merging
Assignee | ||
Comment 16•3 years ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #15)
Upstream PR was closed without merging
As I am new here, I don't understand, what happened can someone explain me.
Comment 17•3 years ago
|
||
(In reply to rai.ankur0007 from comment #16)
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #15)
Upstream PR was closed without merging
As I am new here, I don't understand, what happened can someone explain me.
It is in reference to the PR mentioned in comment 12 - we have automated tools to upstream changes to the web platform tests. In this case the PR had an issue with tests failing, so the closed it and then re-opened it. The warning here was just in case we would need to reconsider the changes made, so we can ignore it. Hopefully there should be a follow-up at some stage where it does get merged.
Upstream PR merged by moz-wptsync-bot
Description
•