Closed Bug 1693199 Opened 4 years ago Closed 4 years ago

Port bug 1692880 - Windows build bustage in MAPI

Categories

(Thunderbird :: Upstream Synchronization, defect)

Product:
Thunderbird
Component:
Upstream Synchronization
Type:
defect

Tracking

(thunderbird_esr78 unaffected)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: addons, Assigned: addons)

Details

Attachments

(1 file)

1693199.patch
1.96 KB, patch
benc
: review+
Details | Diff | Splinter Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.150 Safari/537.36 Edg/88.0.705.68

Steps to reproduce:

https://treeherder.mozilla.org/logviewer?job_id=330152186&repo=comm-central&lineNumber=12744
from
mailnews/mapi/mapihook/src/msgMapiMain.cpp(82,20): note: in instantiation of function template specialization 'nsBaseHashtable<nsUint32HashKey, mozilla::UniquePtr<nsMAPISession, mozilla::DefaultDelete<nsMAPISession>>, nsMAPISession *, nsUniquePtrConverter<nsMAPISession>>::Put<nsMAPISession *&>' requested here
[task 2021-02-16T22:18:40.775Z] 22:18:40 INFO - m_SessionMap.Put(session_generator, pTemp);

Seems to have a problem here:
.\msgMapiMain.h: nsClassHashtable<nsUint32HashKey, nsMAPISession> m_SessionMap;

Attached patch 1693199.patch — — Splinter Review

Something for the night shift ;-)

Attachment #9203572 - Flags: review?(geoff)
Attachment #9203572 - Flags: review?(benc)
Attachment #9203572 - Flags: review?(benc) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5bdeb5baf3fb
Port bug 1692880: Changes to nsBaseHashtable::Put(). r=benc

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → addons
status-thunderbird_esr78: --- → unaffected
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.