Closed Bug 1689119 Opened 4 years ago Closed 4 years ago

Fix potentially duplicated telemetry initialization in "LoginCSVImport.jsm"

Categories

(Toolkit :: Password Manager, defect, P2)

Product:
Toolkit
Component:
Password Manager
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: tgiles, Assigned: petcuandrei)

References

Details

Attachments

(1 file)

Bug 1689119 Fix potentially duplicated telemetry initialization in "LoginCSVImport.jsm"
48 bytes, text/x-phabricator-request
Details | Review

Currently, we do not cancel the telemetry stopwatch if we throw any errors in LoginCSVImport.jsm. This seems like incorrect behavior and will cause the browser_openImportCSV.js test to fail when running the test in --verify mode.

The following are the errors that appear when running browser_openImportCSV.js in --verify mode:

browser/components/aboutlogins/tests/browser/browser_openImportCSV.js
  FAIL [JavaScript Error: "Error: TelemetryStopwatch: key "FX_MIGRATION_LOGINS_IMPORT_MS" was already initialized" {file: "resource://gre/modules/LoginCSVImport.jsm" line: 136}]
importFromCSV@resource://gre/modules/LoginCSVImport.jsm:136:24

resource://specialpowers/SpecialPowersChild.jsm:observe/<:158
  FAIL [JavaScript Error: "Error: TelemetryStopwatch: finishing nonexisting stopwatch. Histogram: "FX_MIGRATION_LOGINS_IMPORT_MS", key: "login_csv"" {file: "resource://gre/modules/LoginCSVImport.jsm" line: 222}]
importFromCSV@resource://gre/modules/LoginCSVImport.jsm:222:26
Blocks: 1688213
Severity: -- → S3
Priority: -- → P2
See Also: → 1687905
Assignee: nobody → petcuandrei
Status: NEW → ASSIGNED
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4947b0149aee
Fix potentially duplicated telemetry initialization in "LoginCSVImport.jsm" r=tgiles

Why is this issue not closed/fixed or something? Does it need to be changed manually?

Flags: needinfo?(tgiles)

It hasn't landed on central yet, so it hasn't been resolved yet. Here's a different bug that shows that process happening

Flags: needinfo?(tgiles)

https://hg.mozilla.org/mozilla-central/rev/4947b0149aee

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.