Closed Bug 1688504 Opened 4 years ago Closed 4 years ago

nsNavHistoryQuery.cpp: do not use 'else' after 'return'

Categories

(Toolkit :: Places, task)

Product:
Toolkit
Component:
Places
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: Sylvestre, Assigned: anuragkalia)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Bug 1688504 - nsNavHistoryQuery.cpp: do not use 'else' after 'return' r?Sylvestre
48 bytes, text/x-phabricator-request
Details | Review

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/7431701c98da9218fda314a54efa1a3093760f65/toolkit/components/places/nsNavHistoryQuery.cpp#553

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Component: General → Places
Product: Core → Toolkit
Assignee: nobody → anurag.kalia
Status: NEW → ASSIGNED
Attachment #9199191 - Attachment description: Bug 1688504 - Address clang-tidy warnings r?Sylvestre → Bug 1688504 - nsNavHistoryQuery.cpp: do not use 'else' after 'return' r?Sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b60c48c8b0d4
nsNavHistoryQuery.cpp: do not use 'else' after 'return' r=sylvestre

https://hg.mozilla.org/mozilla-central/rev/b60c48c8b0d4

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.