Closed Bug 1688503 Opened 4 years ago Closed 4 years ago

nsFirstLetterFrame.cpp: do not use 'else' after 'return'

Categories

(Core :: Layout, task)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: Sylvestre, Assigned: PAWANJBS5)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Bug 1688503 - nsFirstLetterFrame.cpp: do not use 'else' after 'return' r=sylvestre
48 bytes, text/x-phabricator-request
Details | Review

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/layout/generic/nsFirstLetterFrame.cpp#92-93

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

@sylvestre can I take this bug?

Please read the last line of the comment ;)

Removed the 'else' statement to resolve clang-tidy warning.

Assignee: nobody → PAWANJBS5
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0e668f662ab
nsFirstLetterFrame.cpp: do not use 'else' after 'return' r=sylvestre

https://hg.mozilla.org/mozilla-central/rev/a0e668f662ab

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.