Closed Bug 1685638 Opened 4 years ago Closed 4 years ago

Change :not(:disabled) to :enabled in CSS files

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: ntim, Assigned: mick, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file, 3 obsolete files)

Bug 1685638 - Change :not(:disabled) to :enabled in CSS files.
48 bytes, text/x-phabricator-request
Details | Review

https://searchfox.org/mozilla-central/search?q=%3Anot%28%3Adisabled&path=&case=false&regexp=false

:not(:disabled) -> :enabled
:not(:disabled, X) -> :enabled:not(X)

You should not change test usages in this list.

Summary: Change :not(:disabled) to :enabled in browser CSS → Change :not(:disabled) to :enabled in CSS files

HI Tim,
I work on this bug.

Thanks
Abhishek

Assignee: nobody → mick.sharma02
Status: NEW → ASSIGNED

Hi Tim,
I submit the patch. I changed in toolkit/components/printing/content/print.css. I have to change :not(:disabled)to :enabled in all folder like
browser/components/extensions/extension.css
browser/components/protections/content/protections.js
devtools/client/application/src/components/ui/UIButton.css
devtools/client/debugger/src/components/shared/Button/styles/CommandBarButton.css
devtools/client/themes/common.css
toolkit/components/printing/content/print.css
toolkit/themes/shared/in-content/common.inc.css

or only in toolkit folder.

Can you please review it.

Thanks
Abhishek

(In reply to Abhishek Sharma from comment #3)

Hi Tim,
I submit the patch. I changed in toolkit/components/printing/content/print.css. I have to change :not(:disabled)to :enabled in all folder like
browser/components/extensions/extension.css
browser/components/protections/content/protections.js
devtools/client/application/src/components/ui/UIButton.css
devtools/client/debugger/src/components/shared/Button/styles/CommandBarButton.css
devtools/client/themes/common.css
toolkit/components/printing/content/print.css
toolkit/themes/shared/in-content/common.inc.css

or only in toolkit folder.

All files except test files, so yes, the files you mentioned should be updated.

Depends on D101130

Hi Tim,
I changed in all the files that you mentioned above. Can you please review it.

Thanks
Abhishek

Hi Tim,
I combine three patches in one but it does not show.

Abhishek

The introduction channel on chat.mozilla.org should be able to help you.

Attachment #9196021 - Attachment description: "Bug 1685638 - Change :not(:disabled)to :enabled in CSS files in toolkit/components/printing/content/print.css r=ntim" → Bug 1685638 - Change :not(:disabled) to :enabled in CSS files
Attachment #9196243 - Attachment is obsolete: true
Attachment #9196254 - Attachment is obsolete: true
Attachment #9196021 - Attachment description: Bug 1685638 - Change :not(:disabled) to :enabled in CSS files → "Bug 1685638 - Change :not(:disabled)to :enabled in CSS files in toolkit/components/printing/content/print.css r=ntim"

Hi Tim,
I remove the // and also add :enabled outside . Can you please review it.
I hope this time submit the patch.

Thanks
Abhishek

Attachment #9196021 - Attachment description: "Bug 1685638 - Change :not(:disabled)to :enabled in CSS files in toolkit/components/printing/content/print.css r=ntim" → Bug 1685638 - Change :not(:disabled) to :enabled in CSS files.
Attachment #9196753 - Attachment is obsolete: true
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9fe2b19d99d2
Change :not(:disabled) to :enabled in CSS files. r=ntim

https://hg.mozilla.org/mozilla-central/rev/9fe2b19d99d2

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

Hi Tim,
Can u give me other bugs . Its great to work with you. Thanks for helping me in every step and sorry for late work.

Abhishek

(In reply to Abhishek Sharma from comment #15)

Hi Tim,
Can u give me other bugs . Its great to work with you. Thanks for helping me in every step and sorry for late work.

Abhishek

No problem, it's a pleasure to help :)

I don't think I have any more bugs I can suggest on my side. I would suggest checking https://codetribute.mozilla.org/ regarding which topic interests you and choosing a bug from there, or maybe Sylvestre has a bug to suggest?

Flags: needinfo?(sledru)
Regressions: 1695860
You need to log in before you can comment on or make changes to this bug.