WPT test fails for html/canvas/element/pixel-manipulation/2d.imageData.create2.zero.html
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: aryanagal98, Assigned: aryanagal98)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
WPT test for html/canvas/element/pixel-manipulation/2d.imageData.create2.zero.html
fails
FAIL message: assert_throws_dom: function "function() { ctx.createImageData(0.99, 10); }" did not throw
Cross-browser tests (as of bug report):
Chrome | Edge | Firefox | Safari |
---|---|---|---|
PASS | PASS | FAIL | FAIL |
Assignee | ||
Comment 1•4 years ago
|
||
The test can be checked easily at:
https://wpt.fyi/results/html/canvas/element/pixel-manipulation/2d.imageData.create2.zero.html?label=experimental&label=master&aligned
Assignee | ||
Comment 2•4 years ago
|
||
Shifted the zero-check after width and height are clamped to int32s. Fixes the
use case where width and height are floats > 0 but < 1. These values are
clamped to 0, but no error is thrown, as opposed to the desired behavior.
Changed corresponding test to reflect that it is expected to PASS.
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/636bed8f02dc Check for 0 size after clamping in CanvasRenderingContext2D.createImageData r=emilio
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/f70abb51ec6d Fix a test that started failing and checked something against the spec.
Comment 5•4 years ago
|
||
Backed out for causing damp failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/1098ab162ad2352f7623193c1bbb80834d0b5d3a
Failure log: https://treeherder.mozilla.org/logviewer?job_id=325674078&repo=autoland
Comment 6•4 years ago
|
||
This fixes the DAMP failures and effectively preserves behavior.
Comment 7•4 years ago
|
||
(In reply to Atila Butkovits from comment #5)
Failure log: https://treeherder.mozilla.org/logviewer?job_id=325674078&repo=autoland
Code snippet:
[task 2021-01-02T22:56:17.593Z] 22:56:17 ERROR - PID 3956 | Handler function threw an exception: TypeError: can't access property "first", timings.REQUEST_HEADER is undefined
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | Stack: _getBlockedTiming@resource://devtools/server/actors/network-monitor/network-observer.js:1226:7
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | _setupHarTimings@resource://devtools/server/actors/network-monitor/network-observer.js:1419:31
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | _onTransactionClose@resource://devtools/server/actors/network-monitor/network-observer.js:1210:27
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | _dispatchActivity@resource://devtools/server/actors/network-monitor/network-observer.js:632:14
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | NetworkObserver.prototype.observeActivity<@resource://devtools/server/actors/network-monitor/network-observer.js:738:12
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | Line: 1226, column: 7
[task 2021-01-02T22:56:17.593Z] 22:56:17 INFO - PID 3956 | console.error: (new TypeError("can't access property "first", timings.REQUEST_HEADER is undefined", "resource://devtools/server/actors/network-monitor/network-observer.js", 1226))
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/442421e347a1 Fix usage of createImageData in devtools. r=jdescottes
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f813973b02b Check for 0 size after clamping in CanvasRenderingContext2D.createImageData r=emilio
Updated•4 years ago
|
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/442421e347a1
https://hg.mozilla.org/mozilla-central/rev/9f813973b02b
Description
•