Closed Bug 1681889 Opened 4 years ago Closed 4 years ago

Remove defer usage in devtools/client/memory/test/xpcshell/head.js

Categories

(DevTools :: Shared Components, task, P3)

Product:
DevTools
Component:
Shared Components
Type:
task

Tracking

(firefox86 fixed)

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: Honza, Assigned: bfmags, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1681889 - Remove unused `defer` require from devtools/client/memory/test/xpcshell/head.js. r=ntim
48 bytes, text/x-phabricator-request
Details | Review

We should use new Promise instead.

Honza

This is pretty straightforward, since no memory tool test uses defer(), so the following line can just be removed with no extra changes:

https://searchfox.org/mozilla-central/rev/0eebf69d04cc0cdd252b135dda2fa9b7c2fa2bfb/devtools/client/memory/test/xpcshell/head.js#25

Mentor: ntim.bugs
Whiteboard: [lang=js]

Hi Tim, thank you for the clear description for this bug.

This is my first commit, so I hope I followed the correct submission process. Do you mind reviewing this?

Thanks!

Hi Jan (apologies just now realised you are the reporter)
I've submitted a patch following Tim review (I also couldn't find any usages for refer) .
Can you please clarify if any more changes are needed (for using promise).
Thank you

Assignee: nobody → bfmags
Status: NEW → ASSIGNED
Attachment #9194818 - Attachment description: Bug 1681889 Remove unused defer require → Bug 1681889 - [devtools] Remove unused Defer require. r=ntim,honza
Attachment #9194818 - Attachment description: Bug 1681889 - [devtools] Remove unused Defer require. r=ntim,honza → Bug 1681889 - Remove unused `defer` require from devtools/client/memory/test/xpcshell/head.js. r=ntim
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/31ae6edbfb8d
Remove unused `defer` require from devtools/client/memory/test/xpcshell/head.js. r=ntim

https://hg.mozilla.org/mozilla-central/rev/31ae6edbfb8d

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.