Closed Bug 1680751 Opened 4 years ago Closed 3 years ago

Change KeyPathType to an enum class

Categories

(Core :: Storage: IndexedDB, task)

Product:
Core
Component:
Storage: IndexedDB
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: sg, Assigned: dtfranken)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1680751 - Change KeyPathType to an enum class. r=#dom-workers-and-storage-reviewers,ttung
48 bytes, text/x-phabricator-request
Details | Review

KeyPathType (https://searchfox.org/mozilla-central/rev/6bb59b783b193f06d6744c5ccaac69a992e9ee7b/dom/indexedDB/KeyPath.h#32) should be changed to be an enum class (scoped enum) rather than an unscoped enum, and the naming of the enum values be adjusted according to https://firefox-source-docs.mozilla.org/dom/workersAndStorage/CodeStyle.html#enums

Component: General → Storage: IndexedDB
Assignee: nobody → dtfranken
Status: NEW → ASSIGNED

Hi, I'd like to take this as my first bug. I've just submitted a patch - I hope I specified the right review group.

Pushed by bugmail@asutherland.org:
https://hg.mozilla.org/integration/autoland/rev/c169fde425b2
Change KeyPathType to an enum class. r=ttung,dom-storage-reviewers,asuth

https://hg.mozilla.org/mozilla-central/rev/c169fde425b2

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.