Closed Bug 1664259 Opened 4 years ago Closed 3 years ago

Misspelled constant "CAPABILITES_MISMATCH" in Normandy

Categories

(Firefox :: Normandy Client, defect, P5)

Product:
Firefox
Component:
Normandy Client
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mythmon, Assigned: kajalsah107)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

Bug 1664259 - Corrects misspelled constant CAPABILITES_MISMATCH. r?emalysz
48 bytes, text/x-phabricator-request
Details | Review

There is a variable name misspelled in the Normandy capabilities system. This has no impact on the functionality of Normandy, as the misspelling is consistent across the code base. It does however make me confused when my spell checker complains about a perfectly valid variable name. We should fix the spelling mistake.

The definition of the constant is at toolkit/components/normandy/actions/BaseAction.jsm#311.

Keywords: good-first-bug

Hello, I'm new to OSS and I would like to start contributing by solving this issue. Can you please assign this to me and guide me further

Please assign me this bug and guide me further on how to start this

Flags: needinfo?(mcooper)

I've assigned this bug to you. For general instructions, you can see documentation about how to get started submitting patches to Firefox in the Contributors' Quick Reference.

Specific to this bug, you can start by changing the spelling of the constant in BaseAction.jsm, linked from comment 0. From there you can use a search tool like Searchfox to find other places that constant is references.

You can make you updated all the references by running the tests with the command ./mach test toolkit/components/normandy.

Assignee: nobody → ee1190487
Flags: needinfo?(mcooper)

I have changed the spelling only in the file here toolkit/components/normandy/actions/BaseAction.jsm. at 4 occurences including #311. Will that be all?

Please post your changes as a Phabricator patch. I will review your changes there.

Attached file Bug 1664259 misspelled constant fix (obsolete) —

Submitted finally, please review

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: ee1190487 → nobody

hey,
what's the status of this bug
I would like to work on this

Attachment #9179700 - Attachment is obsolete: true

Seems like other commenters above are not actively working on this. I would like to take up this issue. I will come up with a patch soon.

Assignee: nobody → kajalsah107
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4af772585a3d
Corrects misspelled constant CAPABILITES_MISMATCH. r=emalysz

https://hg.mozilla.org/mozilla-central/rev/4af772585a3d

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.