Closed Bug 1663143 Opened 4 years ago Closed 3 years ago

The Avif file Type is displayed as OTHER in about:telemetry#events-tab

Categories

(Firefox :: Downloads Panel, defect, P3)

Product:
Firefox
Component:
Downloads Panel
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox80 --- disabled
firefox81 --- disabled
firefox82 --- disabled
firefox89 --- fixed

People

(Reporter: rdoghi, Assigned: ukohasarah)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1663143 - Display The Avif file Type as avif in about:telemetry#events-tab r=Gijs
48 bytes, text/x-phabricator-request
Details | Review

[Affected versions]:
Beta 81.0b5

[Affected platforms]:
Platforms: Windows 10, MAC OSX, Ubuntu 18.04

[Preconditions]:
Reach about:config and have the following prefs set:
image.avif.enabled - true
browser.download.viewableInternally.enabledTypes = SVG,XML,PDF,WEBP,AVIF

Steps :

  1. Launch the Firefox browser and reach https://mime.ty.ax/
  2. From the Prebuilt section Select the AVIF link and Open it in Firefox.
  3. Reach about:telemetry#events-tab and scrol to the bottom.

Expected Results :
The Value for the object - "file extension" should be AVIF.

Actual Results :
The Value for the object - "file extension" should is displayed as OTHER.

I think the severity for this issue should be an S4 since its a minor issue that will not interfeere with the users experience.

Blocks: 1639067, 1658412
status-firefox80: --- → disabled
status-firefox81: --- → affected

This was an oversight when AVIF was added to the other types in bug 1639067. Should be an easy fix, but a very minor issue especially as AVIF is still preffed off.

Severity: -- → S4
Priority: -- → P3

Sarah, were you still looking for a different bug? If so, perhaps you'd like to take a look at this one? The downloads code records the telemetry here: https://searchfox.org/mozilla-central/rev/3ae6f9e4444f3fbf61034317540d36f621117600/browser/components/downloads/DownloadsCommon.jsm#961-968 and we need to make sure avif files get recorded appropriately.

Flags: needinfo?(ukohasarah)

(In reply to :Gijs (he/him) from comment #3)

Sarah, were you still looking for a different bug? If so, perhaps you'd like to take a look at this one? The downloads code records the telemetry here: https://searchfox.org/mozilla-central/rev/3ae6f9e4444f3fbf61034317540d36f621117600/browser/components/downloads/DownloadsCommon.jsm#961-968 and we need to make sure avif files get recorded appropriately.

Yes please, kindly assign to me, lemme have a crack on this one. :)

Flags: needinfo?(ukohasarah) → needinfo?(gijskruitbosch+bugs)

Done. Let me know if you need any help!

Assignee: nobody → ukohasarah
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/27dbfa69adf6
Display The Avif file Type  as avif in about:telemetry#events-tab r=Gijs

https://hg.mozilla.org/mozilla-central/rev/27dbfa69adf6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.