Closed Bug 1633416 Opened 4 years ago Closed 3 years ago

What are TYPE_UNKNOWN certificates and do we need to consider them in about:certificate?

Categories

(Firefox :: Security, task, P5)

Product:
Firefox
Component:
Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: johannh, Assigned: ryedu.09, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1633416 - Removed all mentions of TYPE_UNKNOWN listed in toolkit/components/certviewer r=prathiksha
48 bytes, text/x-phabricator-request
Details | Review

In https://phabricator.services.mozilla.com/D72194#inline-424701 we were wondering whether we need to display those on about:certificate or not.

We shouldn't need to ever display certificates where the type comes back as "unknown".

Ok, thanks! We can probably make this a mentored bug, the task is to delete all mentions of TYPE_UNKNOWN as listed here: https://searchfox.org/mozilla-central/search?q=TYPE_UNKNOWN&path=toolkit%2Fcomponents%2Fcertviewer&case=false&regexp=false

Mentor: jhofmann

Hello Johann,
Can I take up this issue?
Thanks :)

Assignee: nobody → aarushivij
Status: NEW → ASSIGNED

Absolutely, thanks!

Still looking into this? :)

Flags: needinfo?(aarushivij)
Severity: -- → S4
Severity: S4 → N/A

Gentle ping on aarushivij - do you think you still have time to look at this?

Assignee: aarushivij → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(aarushivij)
Assignee: nobody → ryedu.09
Status: NEW → ASSIGNED
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cf1ca1342352
Removed all mentions of TYPE_UNKNOWN listed in toolkit/components/certviewer r=prathiksha

https://hg.mozilla.org/mozilla-central/rev/cf1ca1342352

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.