Closed Bug 1622683 Opened 4 years ago Closed 4 years ago

dom/websocket: Make it flake8 compliant

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: Sylvestre, Assigned: mail, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 file)

Bug 1622683 - Make dom/websocket flake8 and pylint compliant. r?sylvestre
47 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1622682 +++

Filling as a good first bug to learn workflows.

As the change is easy, it is mostly to learn how to contribute to Firefox.

To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#13

To run the linter:
$ ./mach lint -l flake8 dom/websocket

To run the autofix:
$ ./mach lint -l flake8 --fix dom/websocket/

Then, the remaining thing should be fixed by hand.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Assignee: nobody → pfischbeck
Status: NEW → ASSIGNED
Attachment #9173039 - Attachment description: Bug 1622683 - Make dom/websocket flake8 compliant. r?sylvestre → Bug 1622683 - Make dom/websocket flake8 and pylint compliant. r?sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfd3eb3545d5
Make dom/websocket flake8 and pylint compliant. r=sylvestre

https://hg.mozilla.org/mozilla-central/rev/dfd3eb3545d5

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.