dom/base: Make it flake8 compliant
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(firefox89 fixed)
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: gakshita1405, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
Attachments
(2 files)
Filling as a good first bug to learn workflows.
As the change is easy, it is mostly to learn how to contribute to Firefox.
To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#7
To run the linter:
$ ./mach lint -l flake8 dom/base
To run the autofix:
$ ./mach lint -l flake8 --fix dom/base/
Then, the remaining thing should be fixed by hand.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Line 7 was already uncommented in my flake8
file.
The linter says there's 0 problem in my repository.
Am I missing something?
Reporter | ||
Comment 2•4 years ago
|
||
Hello Pascal,
Sorry, I meant remove, not uncomment.
I can still see it on https://hg.mozilla.org/mozilla-central/file/tip/.flake8
Updated•4 years ago
|
Comment 4•4 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 5•3 years ago
|
||
Updated•3 years ago
|
Pushed by shivams2799@gmail.com: https://hg.mozilla.org/integration/autoland/rev/66198fe5af21 Made dom/base flake8 compliant.r=championshuttler,sylvestre
Comment 7•3 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•