Fix HTML tags in about:networking
Categories
(Core :: Networking, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: valentin, Assigned: freyamehta99, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [necko-triaged])
Attachments
(1 file, 1 obsolete file)
https://phabricator.services.mozilla.com/D60814#inline-368781
Nit: omit / on the newly added meta at least? Throughout, I believe:
link
meta
inputdon't need closing tags, and in HTML /> is meaningless. So there's more that could be done throughout this doc (e.g. the span and th nodes that only get closed by virtue of HTML parsing finding another node and closing it because of that), but I don't want to block you landing this. Up to you if you want to address those here or in another commit/bug or if you want to leave it as-is to preserve blame and will just update iteratively when changing those lines anyway.
All the tags mentioned above (link, meta, input, span, th) that are found in https://searchfox.org/mozilla-central/source/toolkit/content/aboutNetworking.html should be fixed.
If you want to work on this bug let me know so I will assign you to it.
If this is your first contribution this is a good place to start: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
Assignee | ||
Comment 1•5 years ago
|
||
Hi! I am new here.
I would like to take up this bug. Could you assign it to me?
Reporter | ||
Comment 2•5 years ago
|
||
Welcome!
Assignee | ||
Comment 3•5 years ago
|
||
Hi,
I started following this https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction. But while building Firefox for Desktop I encountered this error and I have been working on it since a couple of days now but don't seem to get the hang of the bug.
I did ./mach bootstrap followed by ./mach build. But when I run ./mach run, I get the following error:
freya@freya-HP-Laptop-15-bs1xx:/src/mozilla-central$ ./mach run/src/mozilla-central$ uname -a
0:04.15 /home/freya/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/firefox -no-remote -profile /home/freya/src/mozilla-central/obj-x86_64-pc-linux-gnu/tmp/profile-default
XPCOMGlueLoad error for file /home/freya/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/libxul.so:
/usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by /home/freya/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/libxul.so)
Couldn't load XPCOM.
freya@freya-HP-Laptop-15-bs1xx:
Linux freya-HP-Laptop-15-bs1xx 4.15.0-74-generic #8316.04.1-Ubuntu SMP Wed Dec 18 04:56:23 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux/src/mozilla-central$ lsb_release -cs
freya@freya-HP-Laptop-15-bs1xx:
xenial
I already have gcc-4.9 and libstdc++6 installed and upgraded.
Please kindly help me fix this issue so that I can build my Firefox on the desktop and start working on this bug.
Reporter | ||
Comment 4•5 years ago
|
||
According to https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code the minimum supported version of gcc is 7.1
It would seem you're using Ubuntu 16.04 ? That seems rather old, and probably doesn't have the newer gcc packages.
I encourage you to upgrade to a newer distribution.
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Hi,
I worked on the mozilla-central/toolkit/content/aboutNetworking.html and fixed the told tags (link, meta, input, span, th). I fixed even br, hr, tbody and td tags. I have submitted the commit to review. Let me know if any other changes are required.
Thank you.
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D61409
Comment 8•5 years ago
|
||
Hi! Are you able to update this patch for the last few review nits? If not, could you let us know? Thank you!
Comment 9•5 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:freyamehta99, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•4 years ago
|
Reporter | ||
Comment 10•4 years ago
|
||
Unfortunately these patches need a rebase.
Comment 11•4 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a244a5fb694a Fixed closing of HTML tags in about:networking to not try to be XHTML, r=valentin,Gijs
Comment 13•4 years ago
|
||
I rebased the patch and fixed the remaining comments, but it's still Freya's patch so reverting assignee.
Comment 14•4 years ago
|
||
bugherder |
Description
•