• Resolved Abigailm

    (@abigailm)


    The upgrade to version 7.3.1 messed up the month display — it no longer hides display of specified categories and the Legend Superpowers feature also appears to break with the upgrade. So basically the legend for the month display showed several lines of categories that are ticked off as hidden in the setting, immediately after the allowed categories. And clicking links to the allowed categories didn’t produce any response.

    I have rolled back to version 7.3.0 for now.

    The site is running PHP 8.1.

Viewing 15 replies - 1 through 15 (of 16 total)
  • Plugin Author Gustavo Bordoni

    (@bordoni)

    Would you mind sharing a couple of screenshots of how you have it setup? And potentially a link for the page where it would be broken?

    I want to make sure we can replicate it locally so our team can fix it.

    Plugin Support Darian

    (@d0153)

    Hi @abigailm

    I tried replicating the issue on my end, but it’s working as expected both in versions 7.3.1 and 7.3.0

    There could probably be a plugin/theme conflict on your end. Is it possible for you to create a staging version of your live site and update your plugin to 7.3.1 from there? After that, please send us the link of your calendar so we can investigate the issue further.

    You can use the WP Staging plugin to easily create a staging site.

    Let me know if you have further questions or concerns.

    Plugin Author Andy Fragen

    (@afragen)

    I think I found the issue.

    Can you change line 43 in src/Category_Colors/views/legend.php from

    <?php if ( isset( $options['show_ignored_cats_legend'] ) ) : ?>

    to

    <?php if ( ! empty( $options['show_ignored_cats_legend'] ) ) : ?>

    Let me know if that works.

    Plugin Author Andy Fragen

    (@afragen)

    My assumption is that hidden categories are still being displayed in the legend.

    Thread Starter Abigailm

    (@abigailm)

    Andy — thanks for the code — I tried plugging that in and it did not resolve the problem.

    Basically we have dozens of categories & subcategories set up on our calendar — but we only want a handful of main categories to display on the month view. And we do use the Legend Superpowers feature, because it really is useful with a crowded calendar. We haven’t bothered assiging colors to the many subcategories we want hidden. So what happens with the upgrade instead of just the legend with the assigned colors at the top, we have those items listed- but also another 5 lines of text with all the titles that are supposed to be hidden. And as noted, the Superpowers feature stops working.

    Darian — I appreciate your suggestion, but I don’t have time to mess with a staging site. I rolled back to 7.3.0 and things are working fine — it is only an issue introduced with the update.

    Plugin Author Andy Fragen

    (@afragen)

    Can you share a screenshot of your Category Colors Settings?

    I also found, in testing, that I needed to clear my browser cache.

    Plugin Author Andy Fragen

    (@afragen)

    You might be able to make the change locally on your site to test. Here’s the actual change.

    https://github.com/the-events-calendar/the-events-calendar-category-colors/pull/161/files

    Thread Starter Abigailm

    (@abigailm)

    I did already try to make that change – it didn’t help. I tried again today — here’s a picture of my edit:
    I tried uploading screenshots to Imgur but that site is giving me problems right now.

    I can tell you what I have found.
    With version 7.3.1, both with and without the changed line of code you provided, the console shows a Javascript error at legend-superpowers.js:129
    TypeError: Cannot read properties of null (reading ‘length’)

    For the categories, the source code for the page shows all hidden categories loaded as <li class=”teccc-hidden-category”> … but there is no corresponding CSS style set for that class. So of course the text is displayed on the page. When I rolled back to 7.30, the source code doesn’t show the hidden categories as being included at all.

    Thread Starter Abigailm

    (@abigailm)

    OK, I had to create a new account at Imgur to get things working.

    Here is the Javascript console error:

    Thread Starter Abigailm

    (@abigailm)

    And here is what the source code on the page looks like. Again, this items are displaying because there does not seem to be any corresponding css specs for the defined class:

    Thread Starter Abigailm

    (@abigailm)

    And here is the screenshot of my settings that you asked for:

    Plugin Author Andy Fragen

    (@afragen)

    Hmm, that fix has worked for me and others. There were no changes to the superpowers.js file. With the change in place, clear all your browser caches.

    You may have a JS issue with another plugin that is bleeding over. Can you test by deactivating all other non-TEC related plugins?

    Can you share the calendar URL?

    Thread Starter Abigailm

    (@abigailm)

    It’s not a browser cache issue — I cleared all caches every step along the way.

    The website is at http://www.davistraining.info/events/month/ — but currently is rolled back to 7.3.0 — so you aren’t going to see the issue.

    Plugin Support Darian

    (@d0153)

    Hi @abigailm

    To assist you more effectively, could you please set up a staging version of your live site and then update the Category Colors to the latest version from there?

    If you haven’t created a staging site already, you can use the WP Staging plugin to do so.

    Looking forward to your reply.

    Thread Starter Abigailm

    (@abigailm)

    Darian, I am sorrry but I don’t have time to set up a staging site — it’s easier for me to just stick with version 7.3.0 for now. I can see from other thread here that I am not the only one with this problem. I think it’s obvious that the 7.3.1 release is buggy, at least on some installation. I look forward to whenever you are ready to incorporate the many code changes you have suggested into your next release.

Viewing 15 replies - 1 through 15 (of 16 total)
  • You must be logged in to reply to this topic.