Typo creating a compatibility issue

  • Resolved jadpm

    (@jadpm)


    6 years, 5 months ago

    Hi

    I am one of the authors of Toolset Types. One of our customers is reporting a compatibility issue with this plugin.

    After some debug we noticed what seems to be a typo in one of your scripts, which is hijacking a global JS variable that we use. On our side, we will be probably renaming/prefixing/namespacing that variable in a future release, but I thought it would be a good idea to report this back here too.

    The problem seems to be in this method:
    https://plugins.trac.wordpress.org/browser/ultimate-fields/trunk/js/ultimate-fields.js#L336
    The code declares a type variable (that matchs some data being passed to the method…) but then it is used as types in types = type.split(',');. I do believe there is an “s” missing there.

    Hope this helps.

    Regards.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Radoslav Georgiev

    (@radogeorgiev)

    6 years, 5 months ago

    Hi to you too!

    To be honest, I am actually surprised that the typo is not breaking the whole plugin 🙂

    As for the solution, I am not sure what to propose for two reasons:

    1. If you take a look at https://wordpress.org/plugins/ultimate-fields/advanced/ you will see that even though I updated the plugin 8 months ago, more than half of the install base is using version 1.0. This leads me to believe that even if I release an update that fixes the issue now, few people would get it quickly enough.
    2. I will be releasing a major rewrite in the next few weeks, which would make the fix mostly meaningless, as the majority of people that update their plugins will get the update.

    The only thing that would sort of make sense is to have a small add-on plugin as a gist, which fixes this. However, directing your uses to it would not make more sense than simply telling them to fix the typo. And you can safely do that – as I said, the next release of the plugin will be a complete rewrite, which means that the issue will not re-emerge after our mutual users update the plugin.

    Does this sound sufficient to you?

    Thread Starter jadpm

    (@jadpm)

    6 years, 5 months ago

    I think that there is no rush to release an inmediate update, even less if you have a planned one coming. In the last 8 months we got one compatibility report, which kind of means this is not a high top priority, and we provided a patch ourselves to the client. So we are covered.

    If you ask me, just let this go. I just opened the ticket because I thought it was a good idea to check.

    Thanks!!!

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Typo creating a compatibility issue’ is closed to new replies.