• Resolved estebantejedor

    (@estebantejedor)


    Hello, as you can see on the two attached screenshots, there is an error in the HTML syntax in the Woo_Product_Gallery.php file. It misses single quotation both in the data-template and the data-terms attributes.

    It should be, respectively:

    data-template='{“dir”:”lite”,”file_name”:”default.php”,”name”:”Woo-Product-Gallery”}’

    and:

    data-terms='[“combos”]’

    I have hacked your plugin and fixed it, but to prevent loosing the changes when the plugin is updated, I suggest you to implement the fix as well:

    echo '<ul class="eael-cat-tab" data-layout="' . esc_attr( $settings[ "eael_product_gallery_items_layout" ] ) . '" data-template=' . json_encode( [ 'dir' => $dir_name, 'file_name' =>
    				$this->get_filename_only( $template ), 'name'                                                                                        => $this->process_directory_name() ], 1 ) . '  data-nonce="' . wp_create_nonce( 'eael_product_gallery' ) . '" data-page-id="' . $this->page_id . '" data-widget-id="' . esc_attr( $this->get_id() ) . '" data-widget="' . esc_attr( $this->get_id() ) . '" data-class="' . get_class( $this ) . '" data-args="' . http_build_query( $args ) . '" data-page="1">';
    

    you should add \’ before and after, so the above should be:

    echo '<ul class="eael-cat-tab" data-layout="' . esc_attr( $settings[ "eael_product_gallery_items_layout" ] ) . '" data-template=\'' . json_encode( [ 'dir' => $dir_name, 'file_name' =>
    				$this->get_filename_only( $template ), 'name'                                                                                        => $this->process_directory_name() ], 1 ) . '\'  data-nonce="' . wp_create_nonce( 'eael_product_gallery' ) . '" data-page-id="' . $this->page_id . '" data-widget-id="' . esc_attr( $this->get_id() ) . '" data-widget="' . esc_attr( $this->get_id() ) . '" data-class="' . get_class( $this ) . '" data-args="' . http_build_query( $args ) . '" data-page="1">';
    

    ==================================================

    Similarly, this:

    echo '<li><a href="javascript:;" data-page="1" data-taxonomy="product_cat" data-terms='
    						 . json_encode
    						 ( [ $category->slug ] ) . ' data-id="'
    						 . $category->term_id . '" class="post-list-filter-item ">' . $show_cat_thumb_tag . '' . $category->name . '</a></li>';

    should be:

    echo '<li><a href="javascript:;" data-page="1" data-taxonomy="product_cat" data-terms=\''
    						 . json_encode
    						 ( [ $category->slug ] ) . '\' data-id="'
    						 . $category->term_id . '" class="post-list-filter-item ">' . $show_cat_thumb_tag . '' . $category->name . '</a></li>';
    

    ==================================================

    And just a live below, almost at the end of the file:

    echo '<li><a href="javascript:;" data-page="1" data-taxonomy="product_tag" data-terms='
    						 . json_encode
    						 ( [ $product_tag->slug ] ) . ' data-id="'
    						 . $product_tag->term_id . '" class="post-list-filter-item ">' . $show_cat_thumb_tag . '' . $product_tag->name . '</a></li>';
    

    it should be also:

    echo '<li><a href="javascript:;" data-page="1" data-taxonomy="product_tag" data-terms=\''
    						 . json_encode
    						 ( [ $product_tag->slug ] ) . '\' data-id="'
    						 . $product_tag->term_id . '" class="post-list-filter-item ">' . $show_cat_thumb_tag . '' . $product_tag->name . '</a></li>';
    

    Please, include this fix in your next plugin update.

    Thank you!

    Esteban

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Support Zeba Afia Shama

    (@zebaafiashama)

    Hello estebantejedor 

    Thank you for reaching out and for bringing these potential HTML syntax errors in the Woo_Product_Gallery.php file to our attention. I appreciate you taking the time to provide such detailed information and even the code fix you implemented.

    I’ve forwarded your report and the code fix you suggested to our development team. They’ll investigate the issue further and determine if these are indeed errors that need to be addressed in the plugin’s code.

    I’ll be sure to keep you updated on the progress. Once the development team has reviewed your findings, I’ll let you know if the fix will be integrated into the next plugin update.

    In the meantime, if you have any other questions or concerns, please don’t hesitate to let me know.

    Thank You

    Plugin Support Zeba Afia Shama

    (@zebaafiashama)

    Hello estebantejedor 

    I am writing to update you regarding the bug that was found on the Bug Fix | Woo_Product_Gallery | Error in code — data-template and data-terms attributes. Our development team has been working on fixing the issue, and I am pleased to inform you that the problem has been resolved in the dev version of the plugin.

    Here is the dev version: https://d.pr/f/NZKHGj

    You can check out this reference video on how to upload the dev version and replace it with the previous one: https://d.pr/XpCgsS

    However, please note that the version we are sharing with you is a development version, which may not be stable and could potentially have other issues. We recommend that you test this version thoroughly before using it on your live website.

    Therefore, if you are willing to wait for the released version, we advise you to do so to ensure the best possible user experience on your website.

    Once you have installed and tested the development version of the plugin, please let us know if you encounter any further issues. Our team will be happy to assist you in any way we can.

    Thank You

    Thread Starter estebantejedor

    (@estebantejedor)

    Thank you Zeba! (and all your team) 😊

    Plugin Support Zeba Afia Shama

    (@zebaafiashama)

    Hi estebantejedor

    I wanted to follow up regarding Bug Fix | Woo_Product_Gallery | Error in code — data-template and data-terms attributes. The fix has been released on the latest version of the plugin. Please update your plugin to the latest version and let me know if you face any issues.

    To keep improving our service, would you be willing to spare 30 seconds to leave a review? Your feedback is invaluable to us.

    Thanks in advance!

    Link to review – https://wordpress.org/plugins/essential-addons-for-elementor-lite/#reviews

    Thread Starter estebantejedor

    (@estebantejedor)

    Thank you! Have a great day ☀️

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.