Yay! This is my favorite project so that makes me happy.
As for issues — I’ll hear them anywhere, but yeah, GitHub is more likely to stay on my radar long-term if it’s not a quick fix. I do have issue queues there for both the checker library and the WordPress integration/dashboard.
I’m working on an update this week, so I’ll get that typo quick. The other two —
- For ignored pages — are you seeing this for both “Hide alert for me” and “Mark as OK for all users,” or just the former? If it’s just on “Hide” — that’s as designed, since all users see the same dashboard. If it’s both we’ve got a new bug…
- Automatically clearing issues from the dashboard when a post is deleted is a need-to-do I’m aware of. I figured out how to do that in Drupal over the summer; I think I’ll be able to use pre_delete_post to do the same here, but it may be a next-summer project if it turns out to be as complicated as it was for Drupal.
Thread Starter
mrwweb
(@mrwweb)
@itmaybejj Thanks for the plugin, quick reply, and link to the Github repo. Not sure why I couldn’t find it, but thank you! I’ll file future issues there.
For the “ignored pages” issue, I’m referring to this situation:
- A page is viewed and errors are logged. For example, the /events/ page for The Events Calendar and all it’s related views (list view, paging, etc.)
- I add a selector to the “Turn off Editoria11y if these elements exist” setting
- The pages still appear in the list of issues.
Those issues are unfixable by editors, so it feels like they should go away.
For the post deletion issue, your approach sounds right. I hope it’s easier than Drupal!
And I also ran into the tracked-by-path issue flagged on Github. I’m seeing pages that have had their permalinks changes appear under their old path. Tracking by Post ID definitely feels like a good start, though I can see that it won’t always work for pages like post type archives.
One quick final thought: A delete button for rows in the pages report doesn’t technically solve all these issues, but it would make them and all similar issues much easier to work around. I wonder if that would be a good add in the mean time?
I’ll file my future issues on Github and see if there’s anything else there I can positively weigh in on. Hopefully I can work toward submitting some PRs over time as I spend more time with the plugin! It would be great to have a CONTRIBUTING.md in your repo 😉
Ohhhh interesting. I see why the ignored pages param is working that way…Editoria11y stops bootstrapping itself when it hits that…which means the “done” event never fires…which means it never syncs anything back to the server to remove existing issues. Works fine on a new install, but leaves garbage behind otherwise.
That would be an easy fix…but some people use the same param in cases where they want to hide the checker for certain users, and don’t want to clear results for the URL. I’ll have to sleep on that. I may just compromise by automatically issuing a delete-all request if both the “I got here from the dashboard” and “ignore-all” are present.
I think I’ll work on the delete button first. It’s the easiest next step, and it at least provides a relief valve for frustration while I chase down the harder things.
For contrib…yeah you’re right about that. In the interim I usually give folks a tour of the codebase first if they want to get started. It’s only mildly organized. But there are some…woefully insufficient…notes in the WP repo and the main library.
Just pushed 1.0.13 — no delete buttons or automatic on-delete events yet, but it will now automatically remove the stale result if it encounters a 404, a different page, or a “Turn off Editoria11y if these elements exist” hit when you click through to the page from the dashboard.
Thread Starter
mrwweb
(@mrwweb)
@itmaybejj Awesome! I’m very excited to check out the changes.
I hadn’t thought about the user-role specific hiding, so I can see why you might not want to really add that behavior. I could imagine some type of
“don’t check by path” option that was a clearer “these pages are totally excluded” setting.
I just ran updates on my sites, so I’ll go check out those changes today!
